Skip to content

Conversation

rmannibucau
Copy link
Contributor

@rmannibucau rmannibucau commented Sep 17, 2025

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@rmannibucau rmannibucau force-pushed the dev/1522 branch 3 times, most recently from 6645e00 to b4a20f2 Compare September 17, 2025 16:37
@slawekjaranowski slawekjaranowski self-requested a review September 17, 2025 20:18
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a documentation with describe template context items and with example how to use it.

all parameters should have documentation with since tag

@slawekjaranowski
Copy link
Member

also please fix

[INFO] --- dependency:3.8.1:analyze-only (analyze) @ maven-dependency-plugin --- [WARNING] Used undeclared dependencies found: [WARNING] org.apache.velocity.tools:velocity-tools-generic:jar:3.1:compile [WARNING] org.apache.velocity:velocity-engine-core:jar:2.4:compile 
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add link to example to site.xml

@rmannibucau rmannibucau merged commit 23186d4 into master Sep 18, 2025
57 checks passed
@rmannibucau rmannibucau deleted the dev/1522 branch September 18, 2025 06:03
Copy link

@rmannibucau Please assign appropriate label to PR according to the type of change.

@github-actions github-actions bot added this to the 3.9.0 milestone Sep 18, 2025
@rmannibucau rmannibucau added the enhancement New feature or request label Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants