[TEST] Improve combine_hashes

[Dandandan]

Which issue does this PR close?

• Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

[Dandandan]

run benchmarks

[Dandandan]

run benchmark tpch

[alamb-ghbot]

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve_combine_hashes (3f27ce2) to 1f26716 diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

[Dandandan]

run benchmark tpcds

[alamb-ghbot]

🤖: Benchmark completed

Details

Comparing HEAD and improve_combine_hashes -------------------- Benchmark clickbench_extended.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩ │ QQuery 0 │ 2816.19 ms │ 2709.70 ms │ no change │ │ QQuery 1 │ 1320.10 ms │ 1282.03 ms │ no change │ │ QQuery 2 │ 2565.28 ms │ 2460.34 ms │ no change │ │ QQuery 3 │ 1106.61 ms │ 1219.01 ms │ 1.10x slower │ │ QQuery 4 │ 2356.93 ms │ 2323.28 ms │ no change │ │ QQuery 5 │ 29413.85 ms │ 28746.22 ms │ no change │ │ QQuery 6 │ 4009.74 ms │ 3966.50 ms │ no change │ │ QQuery 7 │ 3991.71 ms │ 3938.06 ms │ no change │ └──────────────┴─────────────┴────────────────────────┴──────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (HEAD) │ 47580.41ms │ │ Total Time (improve_combine_hashes) │ 46645.13ms │ │ Average Time (HEAD) │ 5947.55ms │ │ Average Time (improve_combine_hashes) │ 5830.64ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 7 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴────────────┘ -------------------- Benchmark clickbench_partitioned.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 2.45 ms │ 2.36 ms │ no change │ │ QQuery 1 │ 50.74 ms │ 51.86 ms │ no change │ │ QQuery 2 │ 130.37 ms │ 140.66 ms │ 1.08x slower │ │ QQuery 3 │ 155.48 ms │ 155.95 ms │ no change │ │ QQuery 4 │ 1080.08 ms │ 1121.76 ms │ no change │ │ QQuery 5 │ 1476.24 ms │ 1511.69 ms │ no change │ │ QQuery 6 │ 2.06 ms │ 2.10 ms │ no change │ │ QQuery 7 │ 56.26 ms │ 59.14 ms │ 1.05x slower │ │ QQuery 8 │ 1440.74 ms │ 1531.80 ms │ 1.06x slower │ │ QQuery 9 │ 1835.91 ms │ 1838.52 ms │ no change │ │ QQuery 10 │ 387.08 ms │ 399.43 ms │ no change │ │ QQuery 11 │ 433.56 ms │ 447.57 ms │ no change │ │ QQuery 12 │ 1367.16 ms │ 1379.42 ms │ no change │ │ QQuery 13 │ 2036.58 ms │ 2096.23 ms │ no change │ │ QQuery 14 │ 1263.29 ms │ 1308.54 ms │ no change │ │ QQuery 15 │ 1268.20 ms │ 1293.73 ms │ no change │ │ QQuery 16 │ 2690.22 ms │ 2845.94 ms │ 1.06x slower │ │ QQuery 17 │ 2662.17 ms │ 2822.05 ms │ 1.06x slower │ │ QQuery 18 │ 6102.97 ms │ 5307.42 ms │ +1.15x faster │ │ QQuery 19 │ 120.72 ms │ 120.86 ms │ no change │ │ QQuery 20 │ 1930.80 ms │ 1946.85 ms │ no change │ │ QQuery 21 │ 2250.60 ms │ 2215.42 ms │ no change │ │ QQuery 22 │ 7054.01 ms │ 3795.00 ms │ +1.86x faster │ │ QQuery 23 │ 27959.57 ms │ 12667.89 ms │ +2.21x faster │ │ QQuery 24 │ 224.90 ms │ 223.71 ms │ no change │ │ QQuery 25 │ 492.96 ms │ 476.67 ms │ no change │ │ QQuery 26 │ 230.83 ms │ 226.05 ms │ no change │ │ QQuery 27 │ 2721.17 ms │ 2727.26 ms │ no change │ │ QQuery 28 │ 25079.47 ms │ 24350.97 ms │ no change │ │ QQuery 29 │ 973.65 ms │ 978.22 ms │ no change │ │ QQuery 30 │ 1329.15 ms │ 1383.37 ms │ no change │ │ QQuery 31 │ 1344.64 ms │ 1349.20 ms │ no change │ │ QQuery 32 │ 5323.08 ms │ 4822.66 ms │ +1.10x faster │ │ QQuery 33 │ 6028.38 ms │ 5841.65 ms │ no change │ │ QQuery 34 │ 6495.79 ms │ 5941.22 ms │ +1.09x faster │ │ QQuery 35 │ 1945.10 ms │ 2084.15 ms │ 1.07x slower │ │ QQuery 36 │ 69.05 ms │ 66.02 ms │ no change │ │ QQuery 37 │ 46.19 ms │ 47.31 ms │ no change │ │ QQuery 38 │ 66.15 ms │ 68.38 ms │ no change │ │ QQuery 39 │ 104.74 ms │ 103.99 ms │ no change │ │ QQuery 40 │ 26.68 ms │ 26.75 ms │ no change │ │ QQuery 41 │ 24.01 ms │ 24.99 ms │ no change │ │ QQuery 42 │ 19.78 ms │ 20.91 ms │ 1.06x slower │ └──────────────┴─────────────┴────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩ │ Total Time (HEAD) │ 116302.98ms │ │ Total Time (improve_combine_hashes) │ 95825.65ms │ │ Average Time (HEAD) │ 2704.72ms │ │ Average Time (improve_combine_hashes) │ 2228.50ms │ │ Queries Faster │ 5 │ │ Queries Slower │ 7 │ │ Queries with No Change │ 31 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴─────────────┘ -------------------- Benchmark tpch_mem_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 127.19 ms │ 135.15 ms │ 1.06x slower │ │ QQuery 2 │ 29.38 ms │ 26.63 ms │ +1.10x faster │ │ QQuery 3 │ 37.57 ms │ 37.45 ms │ no change │ │ QQuery 4 │ 28.12 ms │ 28.09 ms │ no change │ │ QQuery 5 │ 87.72 ms │ 86.93 ms │ no change │ │ QQuery 6 │ 19.74 ms │ 19.91 ms │ no change │ │ QQuery 7 │ 221.39 ms │ 234.76 ms │ 1.06x slower │ │ QQuery 8 │ 36.51 ms │ 37.54 ms │ no change │ │ QQuery 9 │ 106.92 ms │ 99.61 ms │ +1.07x faster │ │ QQuery 10 │ 63.26 ms │ 63.79 ms │ no change │ │ QQuery 11 │ 18.71 ms │ 19.10 ms │ no change │ │ QQuery 12 │ 50.53 ms │ 50.76 ms │ no change │ │ QQuery 13 │ 47.38 ms │ 48.18 ms │ no change │ │ QQuery 14 │ 13.98 ms │ 13.68 ms │ no change │ │ QQuery 15 │ 24.77 ms │ 24.17 ms │ no change │ │ QQuery 16 │ 25.44 ms │ 25.55 ms │ no change │ │ QQuery 17 │ 151.73 ms │ 152.04 ms │ no change │ │ QQuery 18 │ 278.88 ms │ 277.68 ms │ no change │ │ QQuery 19 │ 37.24 ms │ 37.05 ms │ no change │ │ QQuery 20 │ 49.03 ms │ 50.82 ms │ no change │ │ QQuery 21 │ 318.46 ms │ 305.07 ms │ no change │ │ QQuery 22 │ 17.49 ms │ 17.57 ms │ no change │ └──────────────┴───────────┴────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (HEAD) │ 1791.44ms │ │ Total Time (improve_combine_hashes) │ 1791.53ms │ │ Average Time (HEAD) │ 81.43ms │ │ Average Time (improve_combine_hashes) │ 81.43ms │ │ Queries Faster │ 2 │ │ Queries Slower │ 2 │ │ Queries with No Change │ 18 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴───────────┘ 

[alamb-ghbot]

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve_combine_hashes (44698d0) to 1f26716 diff using: tpch
Results will be posted here when complete

[alamb-ghbot]

🤖: Benchmark completed

Details

Comparing HEAD and improve_combine_hashes -------------------- Benchmark tpch_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 214.73 ms │ 220.60 ms │ no change │ │ QQuery 2 │ 97.75 ms │ 95.22 ms │ no change │ │ QQuery 3 │ 130.78 ms │ 125.98 ms │ no change │ │ QQuery 4 │ 78.97 ms │ 77.66 ms │ no change │ │ QQuery 5 │ 178.75 ms │ 180.33 ms │ no change │ │ QQuery 6 │ 69.72 ms │ 69.12 ms │ no change │ │ QQuery 7 │ 219.06 ms │ 222.35 ms │ no change │ │ QQuery 8 │ 167.11 ms │ 162.41 ms │ no change │ │ QQuery 9 │ 232.77 ms │ 228.93 ms │ no change │ │ QQuery 10 │ 192.83 ms │ 188.97 ms │ no change │ │ QQuery 11 │ 78.35 ms │ 75.01 ms │ no change │ │ QQuery 12 │ 119.92 ms │ 122.45 ms │ no change │ │ QQuery 13 │ 233.53 ms │ 217.08 ms │ +1.08x faster │ │ QQuery 14 │ 92.54 ms │ 91.38 ms │ no change │ │ QQuery 15 │ 122.11 ms │ 125.89 ms │ no change │ │ QQuery 16 │ 58.45 ms │ 62.48 ms │ 1.07x slower │ │ QQuery 17 │ 272.69 ms │ 276.12 ms │ no change │ │ QQuery 18 │ 316.59 ms │ 327.80 ms │ no change │ │ QQuery 19 │ 139.15 ms │ 140.93 ms │ no change │ │ QQuery 20 │ 127.29 ms │ 132.35 ms │ no change │ │ QQuery 21 │ 261.44 ms │ 267.97 ms │ no change │ │ QQuery 22 │ 43.28 ms │ 43.43 ms │ no change │ └──────────────┴───────────┴────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (HEAD) │ 3447.81ms │ │ Total Time (improve_combine_hashes) │ 3454.47ms │ │ Average Time (HEAD) │ 156.72ms │ │ Average Time (improve_combine_hashes) │ 157.02ms │ │ Queries Faster │ 1 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 20 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴───────────┘ 

[alamb-ghbot]

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve_combine_hashes (44698d0) to 1f26716 diff using: tpcds
Results will be posted here when complete

[alamb-ghbot]

🤖: Benchmark completed

Details

Comparing HEAD and improve_combine_hashes -------------------- Benchmark tpcds_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 62.56 ms │ 62.43 ms │ no change │ │ QQuery 2 │ 207.71 ms │ 205.39 ms │ no change │ │ QQuery 3 │ 158.51 ms │ 156.60 ms │ no change │ │ QQuery 4 │ 2090.44 ms │ 1994.96 ms │ no change │ │ QQuery 5 │ 265.21 ms │ 267.51 ms │ no change │ │ QQuery 6 │ 1539.95 ms │ 1536.80 ms │ no change │ │ QQuery 7 │ 492.92 ms │ 505.25 ms │ no change │ │ QQuery 8 │ 171.14 ms │ 165.13 ms │ no change │ │ QQuery 9 │ 277.80 ms │ 270.56 ms │ no change │ │ QQuery 10 │ 175.37 ms │ 168.36 ms │ no change │ │ QQuery 11 │ 1406.94 ms │ 1350.39 ms │ no change │ │ QQuery 12 │ 75.91 ms │ 70.16 ms │ +1.08x faster │ │ QQuery 13 │ 543.83 ms │ 546.65 ms │ no change │ │ QQuery 14 │ 2000.19 ms │ 1918.22 ms │ no change │ │ QQuery 15 │ 28.68 ms │ 27.84 ms │ no change │ │ QQuery 16 │ 59.65 ms │ 56.71 ms │ no change │ │ QQuery 17 │ 362.46 ms │ 367.19 ms │ no change │ │ QQuery 18 │ 194.65 ms │ 191.41 ms │ no change │ │ QQuery 19 │ 229.14 ms │ 223.51 ms │ no change │ │ QQuery 20 │ 22.79 ms │ 24.19 ms │ 1.06x slower │ │ QQuery 21 │ 35.50 ms │ 34.11 ms │ no change │ │ QQuery 22 │ 969.78 ms │ 962.60 ms │ no change │ │ QQuery 23 │ 1817.40 ms │ 1799.87 ms │ no change │ │ QQuery 24 │ 637.68 ms │ 674.29 ms │ 1.06x slower │ │ QQuery 25 │ 519.97 ms │ 525.00 ms │ no change │ │ QQuery 26 │ 128.07 ms │ 127.42 ms │ no change │ │ QQuery 27 │ 490.96 ms │ 489.58 ms │ no change │ │ QQuery 28 │ 295.45 ms │ 284.28 ms │ no change │ │ QQuery 29 │ 446.62 ms │ 450.55 ms │ no change │ │ QQuery 30 │ 62.74 ms │ 63.33 ms │ no change │ │ QQuery 31 │ 316.90 ms │ 304.23 ms │ no change │ │ QQuery 32 │ 77.97 ms │ 75.74 ms │ no change │ │ QQuery 33 │ 191.37 ms │ 185.86 ms │ no change │ │ QQuery 34 │ 162.32 ms │ 156.21 ms │ no change │ │ QQuery 35 │ 170.82 ms │ 173.97 ms │ no change │ │ QQuery 36 │ 294.66 ms │ 288.68 ms │ no change │ │ QQuery 37 │ 265.97 ms │ 260.48 ms │ no change │ │ QQuery 38 │ 152.36 ms │ 144.93 ms │ no change │ │ QQuery 39 │ 227.94 ms │ 216.80 ms │ no change │ │ QQuery 40 │ 196.97 ms │ 186.60 ms │ +1.06x faster │ │ QQuery 41 │ 18.15 ms │ 17.13 ms │ +1.06x faster │ │ QQuery 42 │ 144.16 ms │ 139.85 ms │ no change │ │ QQuery 43 │ 125.58 ms │ 120.30 ms │ no change │ │ QQuery 44 │ 15.54 ms │ 15.12 ms │ no change │ │ QQuery 45 │ 84.65 ms │ 82.13 ms │ no change │ │ QQuery 46 │ 326.98 ms │ 315.94 ms │ no change │ │ QQuery 47 │ 1288.89 ms │ 1248.21 ms │ no change │ │ QQuery 48 │ 417.79 ms │ 404.58 ms │ no change │ │ QQuery 49 │ 354.58 ms │ 350.89 ms │ no change │ │ QQuery 50 │ 332.17 ms │ 354.96 ms │ 1.07x slower │ │ QQuery 51 │ 299.48 ms │ 295.33 ms │ no change │ │ QQuery 52 │ 143.85 ms │ 143.22 ms │ no change │ │ QQuery 53 │ 148.48 ms │ 147.77 ms │ no change │ │ QQuery 54 │ 210.06 ms │ 203.12 ms │ no change │ │ QQuery 55 │ 141.78 ms │ 140.78 ms │ no change │ │ QQuery 56 │ 198.33 ms │ 189.37 ms │ no change │ │ QQuery 57 │ 317.88 ms │ 322.48 ms │ no change │ │ QQuery 58 │ 510.85 ms │ 496.45 ms │ no change │ │ QQuery 59 │ 291.40 ms │ 296.91 ms │ no change │ │ QQuery 60 │ 204.00 ms │ 194.35 ms │ no change │ │ QQuery 61 │ 237.19 ms │ 238.54 ms │ no change │ │ QQuery 62 │ 1389.98 ms │ 1304.93 ms │ +1.07x faster │ │ QQuery 63 │ 151.99 ms │ 146.20 ms │ no change │ │ QQuery 64 │ 1164.90 ms │ 1158.15 ms │ no change │ │ QQuery 65 │ 363.42 ms │ 348.14 ms │ no change │ │ QQuery 66 │ 396.09 ms │ 398.56 ms │ no change │ │ QQuery 67 │ 643.47 ms │ 649.15 ms │ no change │ │ QQuery 68 │ 379.37 ms │ 374.05 ms │ no change │ │ QQuery 69 │ 165.09 ms │ 162.57 ms │ no change │ │ QQuery 70 │ 523.45 ms │ 511.49 ms │ no change │ │ QQuery 71 │ 185.25 ms │ 181.52 ms │ no change │ │ QQuery 72 │ 2558.78 ms │ 2458.34 ms │ no change │ │ QQuery 73 │ 157.66 ms │ 149.82 ms │ no change │ │ QQuery 74 │ 870.26 ms │ 839.12 ms │ no change │ │ QQuery 75 │ 390.37 ms │ 393.85 ms │ no change │ │ QQuery 76 │ 186.57 ms │ 181.47 ms │ no change │ │ QQuery 77 │ 269.58 ms │ 261.22 ms │ no change │ │ QQuery 78 │ 937.43 ms │ 929.12 ms │ no change │ │ QQuery 79 │ 336.38 ms │ 322.23 ms │ no change │ │ QQuery 80 │ 501.07 ms │ 496.32 ms │ no change │ │ QQuery 81 │ 41.78 ms │ 43.58 ms │ no change │ │ QQuery 82 │ 299.21 ms │ 298.13 ms │ no change │ │ QQuery 83 │ 67.64 ms │ 68.53 ms │ no change │ │ QQuery 84 │ 65.36 ms │ 62.66 ms │ no change │ │ QQuery 85 │ 228.91 ms │ 220.86 ms │ no change │ │ QQuery 86 │ 61.29 ms │ 57.42 ms │ +1.07x faster │ │ QQuery 87 │ 150.05 ms │ 149.31 ms │ no change │ │ QQuery 88 │ 249.29 ms │ 234.53 ms │ +1.06x faster │ │ QQuery 89 │ 173.99 ms │ 166.65 ms │ no change │ │ QQuery 90 │ 37.63 ms │ 35.76 ms │ no change │ │ QQuery 91 │ 98.01 ms │ 95.38 ms │ no change │ │ QQuery 92 │ 77.94 ms │ 76.17 ms │ no change │ │ QQuery 93 │ 270.65 ms │ 269.45 ms │ no change │ │ QQuery 94 │ 85.33 ms │ 85.28 ms │ no change │ │ QQuery 95 │ 261.77 ms │ 254.99 ms │ no change │ │ QQuery 96 │ 114.06 ms │ 105.80 ms │ +1.08x faster │ │ QQuery 97 │ 190.23 ms │ 184.05 ms │ no change │ │ QQuery 98 │ 243.22 ms │ 229.02 ms │ +1.06x faster │ │ QQuery 99 │ 14801.16 ms │ 14699.22 ms │ no change │ └──────────────┴─────────────┴────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (HEAD) │ 52727.75ms │ │ Total Time (improve_combine_hashes) │ 51834.23ms │ │ Average Time (HEAD) │ 532.60ms │ │ Average Time (improve_combine_hashes) │ 523.58ms │ │ Queries Faster │ 8 │ │ Queries Slower │ 3 │ │ Queries with No Change │ 88 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴────────────┘ 

[Dandandan]

run benchmarks

[alamb-ghbot]

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve_combine_hashes (13f2e05) to 1f26716 diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

[Dandandan]

run benchmark tpch tpcds

[alamb-ghbot]

🤖: Benchmark completed

Details

Comparing HEAD and improve_combine_hashes -------------------- Benchmark clickbench_extended.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩ │ QQuery 0 │ 2925.10 ms │ 2897.27 ms │ no change │ │ QQuery 1 │ 1276.49 ms │ 1390.32 ms │ 1.09x slower │ │ QQuery 2 │ 2651.88 ms │ 2671.89 ms │ no change │ │ QQuery 3 │ 1137.10 ms │ 1245.93 ms │ 1.10x slower │ │ QQuery 4 │ 2463.51 ms │ 2467.47 ms │ no change │ │ QQuery 5 │ 30642.43 ms │ 30440.28 ms │ no change │ │ QQuery 6 │ 4098.64 ms │ 4129.33 ms │ no change │ │ QQuery 7 │ 3853.74 ms │ 3849.12 ms │ no change │ └──────────────┴─────────────┴────────────────────────┴──────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (HEAD) │ 49048.89ms │ │ Total Time (improve_combine_hashes) │ 49091.62ms │ │ Average Time (HEAD) │ 6131.11ms │ │ Average Time (improve_combine_hashes) │ 6136.45ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 2 │ │ Queries with No Change │ 6 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴────────────┘ -------------------- Benchmark clickbench_partitioned.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 2.07 ms │ 2.30 ms │ 1.11x slower │ │ QQuery 1 │ 51.09 ms │ 52.14 ms │ no change │ │ QQuery 2 │ 133.07 ms │ 136.05 ms │ no change │ │ QQuery 3 │ 157.82 ms │ 151.61 ms │ no change │ │ QQuery 4 │ 1048.19 ms │ 1098.94 ms │ no change │ │ QQuery 5 │ 1430.43 ms │ 1498.81 ms │ no change │ │ QQuery 6 │ 2.02 ms │ 2.12 ms │ no change │ │ QQuery 7 │ 56.58 ms │ 55.83 ms │ no change │ │ QQuery 8 │ 1377.98 ms │ 1437.01 ms │ no change │ │ QQuery 9 │ 1838.13 ms │ 1888.87 ms │ no change │ │ QQuery 10 │ 390.31 ms │ 382.75 ms │ no change │ │ QQuery 11 │ 433.90 ms │ 438.26 ms │ no change │ │ QQuery 12 │ 1338.90 ms │ 1360.87 ms │ no change │ │ QQuery 13 │ 1962.15 ms │ 2048.97 ms │ no change │ │ QQuery 14 │ 1272.13 ms │ 1297.88 ms │ no change │ │ QQuery 15 │ 1214.11 ms │ 1254.12 ms │ no change │ │ QQuery 16 │ 2601.03 ms │ 2687.60 ms │ no change │ │ QQuery 17 │ 2591.14 ms │ 2677.68 ms │ no change │ │ QQuery 18 │ 5667.38 ms │ 4943.57 ms │ +1.15x faster │ │ QQuery 19 │ 124.72 ms │ 119.96 ms │ no change │ │ QQuery 20 │ 1910.76 ms │ 1866.71 ms │ no change │ │ QQuery 21 │ 2210.01 ms │ 2179.19 ms │ no change │ │ QQuery 22 │ 3747.52 ms │ 3800.20 ms │ no change │ │ QQuery 23 │ 12662.91 ms │ 12528.44 ms │ no change │ │ QQuery 24 │ 219.34 ms │ 224.04 ms │ no change │ │ QQuery 25 │ 485.36 ms │ 490.36 ms │ no change │ │ QQuery 26 │ 218.24 ms │ 238.39 ms │ 1.09x slower │ │ QQuery 27 │ 2712.19 ms │ 2753.77 ms │ no change │ │ QQuery 28 │ 24024.74 ms │ 24468.25 ms │ no change │ │ QQuery 29 │ 974.82 ms │ 1006.84 ms │ no change │ │ QQuery 30 │ 1323.53 ms │ 1365.42 ms │ no change │ │ QQuery 31 │ 1358.19 ms │ 1334.90 ms │ no change │ │ QQuery 32 │ 4828.70 ms │ 4702.57 ms │ no change │ │ QQuery 33 │ 5875.89 ms │ 5782.99 ms │ no change │ │ QQuery 34 │ 6155.51 ms │ 6141.33 ms │ no change │ │ QQuery 35 │ 1874.84 ms │ 2125.02 ms │ 1.13x slower │ │ QQuery 36 │ 67.03 ms │ 67.30 ms │ no change │ │ QQuery 37 │ 48.51 ms │ 46.32 ms │ no change │ │ QQuery 38 │ 66.30 ms │ 69.96 ms │ 1.06x slower │ │ QQuery 39 │ 109.11 ms │ 101.90 ms │ +1.07x faster │ │ QQuery 40 │ 26.26 ms │ 28.22 ms │ 1.07x slower │ │ QQuery 41 │ 23.67 ms │ 25.07 ms │ 1.06x slower │ │ QQuery 42 │ 19.20 ms │ 22.25 ms │ 1.16x slower │ └──────────────┴─────────────┴────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (HEAD) │ 94635.77ms │ │ Total Time (improve_combine_hashes) │ 94904.79ms │ │ Average Time (HEAD) │ 2200.83ms │ │ Average Time (improve_combine_hashes) │ 2207.09ms │ │ Queries Faster │ 2 │ │ Queries Slower │ 7 │ │ Queries with No Change │ 34 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴────────────┘ -------------------- Benchmark tpch_mem_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 130.15 ms │ 144.00 ms │ 1.11x slower │ │ QQuery 2 │ 29.85 ms │ 26.61 ms │ +1.12x faster │ │ QQuery 3 │ 38.33 ms │ 35.77 ms │ +1.07x faster │ │ QQuery 4 │ 28.94 ms │ 28.35 ms │ no change │ │ QQuery 5 │ 88.52 ms │ 88.49 ms │ no change │ │ QQuery 6 │ 20.13 ms │ 19.77 ms │ no change │ │ QQuery 7 │ 218.64 ms │ 220.68 ms │ no change │ │ QQuery 8 │ 37.10 ms │ 38.35 ms │ no change │ │ QQuery 9 │ 104.08 ms │ 103.54 ms │ no change │ │ QQuery 10 │ 64.73 ms │ 63.36 ms │ no change │ │ QQuery 11 │ 18.04 ms │ 17.50 ms │ no change │ │ QQuery 12 │ 50.50 ms │ 50.73 ms │ no change │ │ QQuery 13 │ 48.59 ms │ 47.80 ms │ no change │ │ QQuery 14 │ 14.06 ms │ 13.98 ms │ no change │ │ QQuery 15 │ 24.86 ms │ 24.61 ms │ no change │ │ QQuery 16 │ 24.80 ms │ 25.44 ms │ no change │ │ QQuery 17 │ 153.02 ms │ 148.50 ms │ no change │ │ QQuery 18 │ 279.19 ms │ 280.70 ms │ no change │ │ QQuery 19 │ 37.36 ms │ 36.44 ms │ no change │ │ QQuery 20 │ 49.70 ms │ 49.56 ms │ no change │ │ QQuery 21 │ 319.48 ms │ 305.27 ms │ no change │ │ QQuery 22 │ 17.38 ms │ 18.04 ms │ no change │ └──────────────┴───────────┴────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (HEAD) │ 1797.46ms │ │ Total Time (improve_combine_hashes) │ 1787.47ms │ │ Average Time (HEAD) │ 81.70ms │ │ Average Time (improve_combine_hashes) │ 81.25ms │ │ Queries Faster │ 2 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 19 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴───────────┘ 

[alamb-ghbot]

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve_combine_hashes (13f2e05) to 1f26716 diff using: tpch
Results will be posted here when complete

[alamb-ghbot]

🤖: Benchmark completed

Details

Comparing HEAD and improve_combine_hashes -------------------- Benchmark tpch_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 227.16 ms │ 239.83 ms │ 1.06x slower │ │ QQuery 2 │ 110.09 ms │ 107.13 ms │ no change │ │ QQuery 3 │ 142.76 ms │ 143.91 ms │ no change │ │ QQuery 4 │ 80.65 ms │ 84.13 ms │ no change │ │ QQuery 5 │ 188.65 ms │ 191.88 ms │ no change │ │ QQuery 6 │ 70.01 ms │ 73.58 ms │ 1.05x slower │ │ QQuery 7 │ 237.07 ms │ 237.95 ms │ no change │ │ QQuery 8 │ 173.68 ms │ 182.53 ms │ 1.05x slower │ │ QQuery 9 │ 240.89 ms │ 236.35 ms │ no change │ │ QQuery 10 │ 206.02 ms │ 189.91 ms │ +1.08x faster │ │ QQuery 11 │ 86.67 ms │ 75.38 ms │ +1.15x faster │ │ QQuery 12 │ 122.92 ms │ 119.63 ms │ no change │ │ QQuery 13 │ 244.72 ms │ 215.31 ms │ +1.14x faster │ │ QQuery 14 │ 99.62 ms │ 97.01 ms │ no change │ │ QQuery 15 │ 130.98 ms │ 123.05 ms │ +1.06x faster │ │ QQuery 16 │ 65.39 ms │ 64.00 ms │ no change │ │ QQuery 17 │ 318.46 ms │ 299.22 ms │ +1.06x faster │ │ QQuery 18 │ 350.14 ms │ 345.03 ms │ no change │ │ QQuery 19 │ 142.83 ms │ 143.72 ms │ no change │ │ QQuery 20 │ 134.19 ms │ 125.80 ms │ +1.07x faster │ │ QQuery 21 │ 286.08 ms │ 271.71 ms │ +1.05x faster │ │ QQuery 22 │ 43.36 ms │ 43.00 ms │ no change │ └──────────────┴───────────┴────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (HEAD) │ 3702.34ms │ │ Total Time (improve_combine_hashes) │ 3610.07ms │ │ Average Time (HEAD) │ 168.29ms │ │ Average Time (improve_combine_hashes) │ 164.09ms │ │ Queries Faster │ 7 │ │ Queries Slower │ 3 │ │ Queries with No Change │ 12 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴───────────┘ 

[alamb-ghbot]

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve_combine_hashes (13f2e05) to 1f26716 diff using: tpcds
Results will be posted here when complete

[alamb-ghbot]

🤖: Benchmark completed

Details

Comparing HEAD and improve_combine_hashes -------------------- Benchmark tpcds_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 67.95 ms │ 63.86 ms │ +1.06x faster │ │ QQuery 2 │ 213.04 ms │ 200.27 ms │ +1.06x faster │ │ QQuery 3 │ 168.42 ms │ 158.80 ms │ +1.06x faster │ │ QQuery 4 │ 1971.93 ms │ 2105.67 ms │ 1.07x slower │ │ QQuery 5 │ 258.66 ms │ 263.18 ms │ no change │ │ QQuery 6 │ 1586.12 ms │ 1519.97 ms │ no change │ │ QQuery 7 │ 600.14 ms │ 513.49 ms │ +1.17x faster │ │ QQuery 8 │ 184.80 ms │ 170.46 ms │ +1.08x faster │ │ QQuery 9 │ 288.52 ms │ 283.98 ms │ no change │ │ QQuery 10 │ 180.69 ms │ 178.55 ms │ no change │ │ QQuery 11 │ 1524.67 ms │ 1502.90 ms │ no change │ │ QQuery 12 │ 84.08 ms │ 73.92 ms │ +1.14x faster │ │ QQuery 13 │ 629.19 ms │ 566.69 ms │ +1.11x faster │ │ QQuery 14 │ 2167.97 ms │ 1992.75 ms │ +1.09x faster │ │ QQuery 15 │ 32.41 ms │ 27.92 ms │ +1.16x faster │ │ QQuery 16 │ 65.95 ms │ 57.95 ms │ +1.14x faster │ │ QQuery 17 │ 404.53 ms │ 359.71 ms │ +1.12x faster │ │ QQuery 18 │ 200.45 ms │ 194.01 ms │ no change │ │ QQuery 19 │ 245.81 ms │ 228.21 ms │ +1.08x faster │ │ QQuery 20 │ 24.56 ms │ 24.03 ms │ no change │ │ QQuery 21 │ 37.57 ms │ 35.06 ms │ +1.07x faster │ │ QQuery 22 │ 1159.93 ms │ 1010.03 ms │ +1.15x faster │ │ QQuery 23 │ 1934.57 ms │ 1834.89 ms │ +1.05x faster │ │ QQuery 24 │ 709.17 ms │ 639.07 ms │ +1.11x faster │ │ QQuery 25 │ 586.93 ms │ 521.96 ms │ +1.12x faster │ │ QQuery 26 │ 145.04 ms │ 128.87 ms │ +1.13x faster │ │ QQuery 27 │ 519.33 ms │ 501.63 ms │ no change │ │ QQuery 28 │ 300.39 ms │ 289.02 ms │ no change │ │ QQuery 29 │ 457.76 ms │ 449.11 ms │ no change │ │ QQuery 30 │ 66.19 ms │ 64.09 ms │ no change │ │ QQuery 31 │ 308.06 ms │ 297.18 ms │ no change │ │ QQuery 32 │ 80.01 ms │ 78.29 ms │ no change │ │ QQuery 33 │ 199.23 ms │ 191.38 ms │ no change │ │ QQuery 34 │ 162.64 ms │ 165.61 ms │ no change │ │ QQuery 35 │ 179.23 ms │ 177.66 ms │ no change │ │ QQuery 36 │ 300.54 ms │ 296.28 ms │ no change │ │ QQuery 37 │ 262.17 ms │ 261.95 ms │ no change │ │ QQuery 38 │ 153.44 ms │ 158.52 ms │ no change │ │ QQuery 39 │ 233.94 ms │ 248.04 ms │ 1.06x slower │ │ QQuery 40 │ 198.35 ms │ 200.78 ms │ no change │ │ QQuery 41 │ 16.92 ms │ 17.34 ms │ no change │ │ QQuery 42 │ 145.15 ms │ 144.66 ms │ no change │ │ QQuery 43 │ 126.28 ms │ 125.93 ms │ no change │ │ QQuery 44 │ 15.84 ms │ 17.42 ms │ 1.10x slower │ │ QQuery 45 │ 85.09 ms │ 84.00 ms │ no change │ │ QQuery 46 │ 339.18 ms │ 345.20 ms │ no change │ │ QQuery 47 │ 1434.29 ms │ 1375.55 ms │ no change │ │ QQuery 48 │ 433.60 ms │ 415.01 ms │ no change │ │ QQuery 49 │ 362.94 ms │ 356.48 ms │ no change │ │ QQuery 50 │ 356.68 ms │ 343.57 ms │ no change │ │ QQuery 51 │ 302.18 ms │ 292.03 ms │ no change │ │ QQuery 52 │ 144.58 ms │ 143.11 ms │ no change │ │ QQuery 53 │ 150.38 ms │ 144.93 ms │ no change │ │ QQuery 54 │ 210.37 ms │ 209.26 ms │ no change │ │ QQuery 55 │ 144.32 ms │ 143.15 ms │ no change │ │ QQuery 56 │ 197.67 ms │ 187.13 ms │ +1.06x faster │ │ QQuery 57 │ 326.81 ms │ 343.45 ms │ 1.05x slower │ │ QQuery 58 │ 522.13 ms │ 529.90 ms │ no change │ │ QQuery 59 │ 295.80 ms │ 302.58 ms │ no change │ │ QQuery 60 │ 201.21 ms │ 201.35 ms │ no change │ │ QQuery 61 │ 247.21 ms │ 241.22 ms │ no change │ │ QQuery 62 │ 1424.11 ms │ 1418.70 ms │ no change │ │ QQuery 63 │ 152.79 ms │ 152.05 ms │ no change │ │ QQuery 64 │ 1198.61 ms │ 1197.58 ms │ no change │ │ QQuery 65 │ 376.94 ms │ 364.49 ms │ no change │ │ QQuery 66 │ 406.42 ms │ 401.97 ms │ no change │ │ QQuery 67 │ 647.20 ms │ 652.24 ms │ no change │ │ QQuery 68 │ 378.08 ms │ 383.94 ms │ no change │ │ QQuery 69 │ 167.01 ms │ 175.16 ms │ no change │ │ QQuery 70 │ 522.80 ms │ 515.26 ms │ no change │ │ QQuery 71 │ 183.20 ms │ 185.94 ms │ no change │ │ QQuery 72 │ 2523.10 ms │ 2634.26 ms │ no change │ │ QQuery 73 │ 161.24 ms │ 157.91 ms │ no change │ │ QQuery 74 │ 959.91 ms │ 907.34 ms │ +1.06x faster │ │ QQuery 75 │ 393.69 ms │ 387.53 ms │ no change │ │ QQuery 76 │ 199.05 ms │ 191.54 ms │ no change │ │ QQuery 77 │ 266.89 ms │ 270.16 ms │ no change │ │ QQuery 78 │ 939.86 ms │ 984.82 ms │ no change │ │ QQuery 79 │ 339.96 ms │ 359.29 ms │ 1.06x slower │ │ QQuery 80 │ 499.17 ms │ 503.61 ms │ no change │ │ QQuery 81 │ 43.08 ms │ 43.18 ms │ no change │ │ QQuery 82 │ 300.11 ms │ 305.75 ms │ no change │ │ QQuery 83 │ 71.53 ms │ 70.24 ms │ no change │ │ QQuery 84 │ 64.69 ms │ 63.01 ms │ no change │ │ QQuery 85 │ 231.77 ms │ 228.70 ms │ no change │ │ QQuery 86 │ 60.53 ms │ 62.65 ms │ no change │ │ QQuery 87 │ 156.77 ms │ 154.27 ms │ no change │ │ QQuery 88 │ 256.45 ms │ 247.91 ms │ no change │ │ QQuery 89 │ 175.29 ms │ 171.92 ms │ no change │ │ QQuery 90 │ 38.04 ms │ 37.84 ms │ no change │ │ QQuery 91 │ 100.14 ms │ 97.70 ms │ no change │ │ QQuery 92 │ 78.82 ms │ 78.71 ms │ no change │ │ QQuery 93 │ 279.05 ms │ 274.37 ms │ no change │ │ QQuery 94 │ 89.16 ms │ 88.40 ms │ no change │ │ QQuery 95 │ 267.98 ms │ 260.88 ms │ no change │ │ QQuery 96 │ 117.66 ms │ 117.09 ms │ no change │ │ QQuery 97 │ 195.96 ms │ 192.01 ms │ no change │ │ QQuery 98 │ 249.97 ms │ 244.65 ms │ no change │ │ QQuery 99 │ 14867.14 ms │ 14686.81 ms │ no change │ └──────────────┴─────────────┴────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (HEAD) │ 54337.16ms │ │ Total Time (improve_combine_hashes) │ 53268.93ms │ │ Average Time (HEAD) │ 548.86ms │ │ Average Time (improve_combine_hashes) │ 538.07ms │ │ Queries Faster │ 20 │ │ Queries Slower │ 5 │ │ Queries with No Change │ 74 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴────────────┘ 

[alamb]

run benchmark with_hashes

[alamb-ghbot]

🤖 ./gh_compare_branch_bench.sh compare_branch_bench.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve_combine_hashes (13f2e05) to 1f26716 diff
BENCH_NAME=with_hashes
BENCH_COMMAND=cargo bench --features=parquet --bench with_hashes
BENCH_FILTER=
BENCH_BRANCH_NAME=improve_combine_hashes
Results will be posted here when complete

[alamb-ghbot]

Benchmark script failed with exit code 101.

Last 10 lines of output:

Click to expand

 substr_index sum to_char to_hex to_timestamp topk_aggregate trunc upper uuid window_query_sql 

[Dandandan]

run benchmark tpch tpcds

[alamb-ghbot]

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve_combine_hashes (13f2e05) to 1f26716 diff using: tpch
Results will be posted here when complete

[alamb-ghbot]

🤖: Benchmark completed

Details

Comparing HEAD and improve_combine_hashes -------------------- Benchmark tpch_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩ │ QQuery 1 │ 214.42 ms │ 231.50 ms │ 1.08x slower │ │ QQuery 2 │ 94.27 ms │ 93.72 ms │ no change │ │ QQuery 3 │ 124.33 ms │ 126.88 ms │ no change │ │ QQuery 4 │ 76.17 ms │ 76.18 ms │ no change │ │ QQuery 5 │ 173.01 ms │ 170.75 ms │ no change │ │ QQuery 6 │ 67.67 ms │ 66.23 ms │ no change │ │ QQuery 7 │ 209.37 ms │ 214.25 ms │ no change │ │ QQuery 8 │ 159.11 ms │ 159.74 ms │ no change │ │ QQuery 9 │ 221.50 ms │ 226.06 ms │ no change │ │ QQuery 10 │ 187.46 ms │ 193.35 ms │ no change │ │ QQuery 11 │ 74.56 ms │ 75.78 ms │ no change │ │ QQuery 12 │ 118.33 ms │ 118.21 ms │ no change │ │ QQuery 13 │ 218.44 ms │ 209.46 ms │ no change │ │ QQuery 14 │ 93.86 ms │ 92.42 ms │ no change │ │ QQuery 15 │ 122.74 ms │ 122.45 ms │ no change │ │ QQuery 16 │ 57.59 ms │ 61.00 ms │ 1.06x slower │ │ QQuery 17 │ 269.86 ms │ 275.21 ms │ no change │ │ QQuery 18 │ 316.04 ms │ 318.28 ms │ no change │ │ QQuery 19 │ 137.61 ms │ 137.23 ms │ no change │ │ QQuery 20 │ 123.46 ms │ 124.03 ms │ no change │ │ QQuery 21 │ 259.24 ms │ 259.51 ms │ no change │ │ QQuery 22 │ 42.67 ms │ 44.63 ms │ no change │ └──────────────┴───────────┴────────────────────────┴──────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (HEAD) │ 3361.69ms │ │ Total Time (improve_combine_hashes) │ 3396.89ms │ │ Average Time (HEAD) │ 152.80ms │ │ Average Time (improve_combine_hashes) │ 154.40ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 2 │ │ Queries with No Change │ 20 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴───────────┘ 

[alamb-ghbot]

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve_combine_hashes (13f2e05) to 1f26716 diff using: tpcds
Results will be posted here when complete

[alamb-ghbot]

🤖: Benchmark completed

Details

Comparing HEAD and improve_combine_hashes -------------------- Benchmark tpcds_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ improve_combine_hashes ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩ │ QQuery 1 │ 62.19 ms │ 62.23 ms │ no change │ │ QQuery 2 │ 206.49 ms │ 197.23 ms │ no change │ │ QQuery 3 │ 159.74 ms │ 155.78 ms │ no change │ │ QQuery 4 │ 1975.83 ms │ 1992.04 ms │ no change │ │ QQuery 5 │ 271.82 ms │ 261.43 ms │ no change │ │ QQuery 6 │ 1521.31 ms │ 1517.03 ms │ no change │ │ QQuery 7 │ 491.50 ms │ 495.18 ms │ no change │ │ QQuery 8 │ 169.27 ms │ 164.98 ms │ no change │ │ QQuery 9 │ 277.03 ms │ 273.03 ms │ no change │ │ QQuery 10 │ 173.01 ms │ 169.61 ms │ no change │ │ QQuery 11 │ 1348.12 ms │ 1363.22 ms │ no change │ │ QQuery 12 │ 70.93 ms │ 72.22 ms │ no change │ │ QQuery 13 │ 542.50 ms │ 546.95 ms │ no change │ │ QQuery 14 │ 1989.90 ms │ 1906.36 ms │ no change │ │ QQuery 15 │ 28.17 ms │ 27.69 ms │ no change │ │ QQuery 16 │ 58.72 ms │ 57.73 ms │ no change │ │ QQuery 17 │ 357.60 ms │ 359.87 ms │ no change │ │ QQuery 18 │ 188.94 ms │ 190.85 ms │ no change │ │ QQuery 19 │ 226.75 ms │ 222.99 ms │ no change │ │ QQuery 20 │ 21.97 ms │ 24.09 ms │ 1.10x slower │ │ QQuery 21 │ 34.26 ms │ 34.77 ms │ no change │ │ QQuery 22 │ 943.55 ms │ 943.46 ms │ no change │ │ QQuery 23 │ 1790.44 ms │ 1801.27 ms │ no change │ │ QQuery 24 │ 631.40 ms │ 631.46 ms │ no change │ │ QQuery 25 │ 508.78 ms │ 508.62 ms │ no change │ │ QQuery 26 │ 128.82 ms │ 123.45 ms │ no change │ │ QQuery 27 │ 497.28 ms │ 483.17 ms │ no change │ │ QQuery 28 │ 284.32 ms │ 288.69 ms │ no change │ │ QQuery 29 │ 444.11 ms │ 443.47 ms │ no change │ │ QQuery 30 │ 61.80 ms │ 62.50 ms │ no change │ │ QQuery 31 │ 289.19 ms │ 295.20 ms │ no change │ │ QQuery 32 │ 75.49 ms │ 76.34 ms │ no change │ │ QQuery 33 │ 193.47 ms │ 188.31 ms │ no change │ │ QQuery 34 │ 162.06 ms │ 157.94 ms │ no change │ │ QQuery 35 │ 170.44 ms │ 172.75 ms │ no change │ │ QQuery 36 │ 291.39 ms │ 285.03 ms │ no change │ │ QQuery 37 │ 263.44 ms │ 260.70 ms │ no change │ │ QQuery 38 │ 151.18 ms │ 145.96 ms │ no change │ │ QQuery 39 │ 215.35 ms │ 213.62 ms │ no change │ │ QQuery 40 │ 189.03 ms │ 190.02 ms │ no change │ │ QQuery 41 │ 16.39 ms │ 17.48 ms │ 1.07x slower │ │ QQuery 42 │ 141.62 ms │ 138.52 ms │ no change │ │ QQuery 43 │ 125.32 ms │ 120.11 ms │ no change │ │ QQuery 44 │ 15.37 ms │ 15.54 ms │ no change │ │ QQuery 45 │ 83.51 ms │ 80.21 ms │ no change │ │ QQuery 46 │ 324.58 ms │ 318.60 ms │ no change │ │ QQuery 47 │ 1251.86 ms │ 1251.31 ms │ no change │ │ QQuery 48 │ 410.53 ms │ 412.68 ms │ no change │ │ QQuery 49 │ 356.66 ms │ 353.10 ms │ no change │ │ QQuery 50 │ 340.14 ms │ 346.15 ms │ no change │ │ QQuery 51 │ 296.30 ms │ 288.63 ms │ no change │ │ QQuery 52 │ 143.77 ms │ 141.05 ms │ no change │ │ QQuery 53 │ 147.71 ms │ 144.79 ms │ no change │ │ QQuery 54 │ 206.43 ms │ 202.44 ms │ no change │ │ QQuery 55 │ 141.88 ms │ 139.92 ms │ no change │ │ QQuery 56 │ 191.41 ms │ 188.11 ms │ no change │ │ QQuery 57 │ 316.54 ms │ 314.78 ms │ no change │ │ QQuery 58 │ 502.25 ms │ 498.45 ms │ no change │ │ QQuery 59 │ 286.95 ms │ 283.99 ms │ no change │ │ QQuery 60 │ 197.41 ms │ 195.87 ms │ no change │ │ QQuery 61 │ 233.72 ms │ 235.04 ms │ no change │ │ QQuery 62 │ 1330.83 ms │ 1310.37 ms │ no change │ │ QQuery 63 │ 148.50 ms │ 148.31 ms │ no change │ │ QQuery 64 │ 1152.45 ms │ 1140.69 ms │ no change │ │ QQuery 65 │ 351.17 ms │ 346.83 ms │ no change │ │ QQuery 66 │ 400.11 ms │ 382.39 ms │ no change │ │ QQuery 67 │ 632.02 ms │ 633.11 ms │ no change │ │ QQuery 68 │ 372.13 ms │ 371.28 ms │ no change │ │ QQuery 69 │ 170.61 ms │ 164.93 ms │ no change │ │ QQuery 70 │ 509.09 ms │ 508.14 ms │ no change │ │ QQuery 71 │ 182.33 ms │ 179.08 ms │ no change │ │ QQuery 72 │ 2488.35 ms │ 2435.25 ms │ no change │ │ QQuery 73 │ 158.00 ms │ 154.35 ms │ no change │ │ QQuery 74 │ 867.87 ms │ 838.83 ms │ no change │ │ QQuery 75 │ 399.97 ms │ 381.76 ms │ no change │ │ QQuery 76 │ 181.29 ms │ 182.50 ms │ no change │ │ QQuery 77 │ 267.47 ms │ 259.26 ms │ no change │ │ QQuery 78 │ 927.96 ms │ 933.43 ms │ no change │ │ QQuery 79 │ 331.70 ms │ 335.27 ms │ no change │ │ QQuery 80 │ 491.58 ms │ 491.58 ms │ no change │ │ QQuery 81 │ 41.89 ms │ 42.73 ms │ no change │ │ QQuery 82 │ 298.79 ms │ 297.84 ms │ no change │ │ QQuery 83 │ 67.73 ms │ 67.98 ms │ no change │ │ QQuery 84 │ 62.74 ms │ 61.57 ms │ no change │ │ QQuery 85 │ 223.76 ms │ 228.94 ms │ no change │ │ QQuery 86 │ 58.84 ms │ 61.23 ms │ no change │ │ QQuery 87 │ 150.93 ms │ 148.51 ms │ no change │ │ QQuery 88 │ 247.45 ms │ 237.06 ms │ no change │ │ QQuery 89 │ 168.55 ms │ 167.85 ms │ no change │ │ QQuery 90 │ 35.15 ms │ 35.52 ms │ no change │ │ QQuery 91 │ 93.03 ms │ 94.22 ms │ no change │ │ QQuery 92 │ 76.61 ms │ 76.29 ms │ no change │ │ QQuery 93 │ 265.83 ms │ 266.33 ms │ no change │ │ QQuery 94 │ 85.91 ms │ 85.16 ms │ no change │ │ QQuery 95 │ 261.22 ms │ 259.79 ms │ no change │ │ QQuery 96 │ 110.00 ms │ 106.62 ms │ no change │ │ QQuery 97 │ 184.17 ms │ 180.08 ms │ no change │ │ QQuery 98 │ 234.48 ms │ 228.67 ms │ no change │ │ QQuery 99 │ 14666.12 ms │ 14636.64 ms │ no change │ └──────────────┴─────────────┴────────────────────────┴──────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (HEAD) │ 51894.57ms │ │ Total Time (improve_combine_hashes) │ 51534.37ms │ │ Average Time (HEAD) │ 524.19ms │ │ Average Time (improve_combine_hashes) │ 520.55ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 2 │ │ Queries with No Change │ 97 │ │ Queries with Failure │ 0 │ └───────────────────────────────────────┴────────────┘ 

[Dandandan]

This does not show much difference (the idea is that the current combine_hashes is not of really high quality / doesn't mix the bits very well. It seems not easy to show cases where this is problematic as long as one of the hashes is of good enough quality 🤔

[alamb]

run benchmark with_hashes

[alamb-ghbot]

🤖 ./gh_compare_branch_bench.sh compare_branch_bench.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve_combine_hashes (9d2c1a9) to 2e3707e diff
BENCH_NAME=with_hashes
BENCH_COMMAND=cargo bench --features=parquet --bench with_hashes
BENCH_FILTER=
BENCH_BRANCH_NAME=improve_combine_hashes
Results will be posted here when complete

[alamb]

(I am trying to run the hash micro benchmark to see if we can see any difference)

[alamb-ghbot]

🤖: Benchmark completed

Details

group improve_combine_hashes main ----- ---------------------- ---- dictionary_utf8_int32: multiple, no nulls 1.26 103.5±3.97µs ? ?/sec 1.00 81.9±0.88µs ? ?/sec dictionary_utf8_int32: multiple, nulls 1.18 134.2±1.69µs ? ?/sec 1.00 113.6±3.38µs ? ?/sec dictionary_utf8_int32: single, no nulls 1.00 27.2±0.23µs ? ?/sec 1.18 32.2±0.24µs ? ?/sec dictionary_utf8_int32: single, nulls 1.00 38.6±0.74µs ? ?/sec 1.00 38.6±1.86µs ? ?/sec int64: multiple, no nulls 1.32 51.4±0.28µs ? ?/sec 1.00 38.8±0.19µs ? ?/sec int64: multiple, nulls 1.00 65.6±0.32µs ? ?/sec 1.14 75.1±2.19µs ? ?/sec int64: single, no nulls 1.02 11.6±0.03µs ? ?/sec 1.00 11.3±0.08µs ? ?/sec int64: single, nulls 1.00 16.5±0.10µs ? ?/sec 1.45 23.9±0.13µs ? ?/sec large_utf8: multiple, no nulls 1.10 244.4±11.23µs ? ?/sec 1.00 222.6±6.40µs ? ?/sec large_utf8: multiple, nulls 1.04 283.9±3.02µs ? ?/sec 1.00 271.9±4.20µs ? ?/sec large_utf8: single, no nulls 1.02 68.3±0.57µs ? ?/sec 1.00 67.2±0.80µs ? ?/sec large_utf8: single, nulls 1.02 79.0±0.91µs ? ?/sec 1.00 77.9±0.79µs ? ?/sec utf8: multiple, no nulls 1.02 239.8±1.65µs ? ?/sec 1.00 234.6±1.23µs ? ?/sec utf8: multiple, nulls 1.05 284.4±2.10µs ? ?/sec 1.00 270.7±1.55µs ? ?/sec utf8: single, no nulls 1.01 68.4±1.91µs ? ?/sec 1.00 67.6±0.65µs ? ?/sec utf8: single, nulls 1.02 79.5±1.25µs ? ?/sec 1.00 77.6±1.14µs ? ?/sec utf8_view (small): multiple, no nulls 1.06 204.4±0.85µs ? ?/sec 1.00 191.9±2.98µs ? ?/sec utf8_view (small): multiple, nulls 1.04 251.5±1.39µs ? ?/sec 1.00 241.3±2.74µs ? ?/sec utf8_view (small): single, no nulls 1.00 59.9±0.41µs ? ?/sec 1.00 59.7±0.59µs ? ?/sec utf8_view (small): single, nulls 1.04 76.6±0.46µs ? ?/sec 1.00 73.6±0.54µs ? ?/sec utf8_view: multiple, no nulls 1.06 278.7±6.02µs ? ?/sec 1.00 262.5±1.30µs ? ?/sec utf8_view: multiple, nulls 1.06 320.8±7.89µs ? ?/sec 1.00 303.7±6.00µs ? ?/sec utf8_view: single, no nulls 1.01 75.7±0.99µs ? ?/sec 1.00 74.8±1.33µs ? ?/sec utf8_view: single, nulls 1.04 93.7±2.10µs ? ?/sec 1.00 90.4±0.67µs ? ?/sec 

[Dandandan]

If anything, it should be a bit slower (because of extra instructions).

I wrote a test that shows this method to be better when the resulting hash output is of low quality (only bits on the right side), but normal "random" bits seem to work just fine for the usecase of partitioning.

It would be probably even better to avoid using a hash combine method and directly use the hasher on multiple columns 🤔