fix(material/menu): fix divider color property #31815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The material/divider component sets its color using the `border-top-color` but the material/menu component attempts to override this by setting the `color` property which causes any overrides to not get applied.
tonyruscoe requested review from crisbeto and wagnermaciel and removed request for a team 
adolgachev added action: global presubmit adolgachev requested review from adolgachev and removed request for crisbeto and wagnermaciel 
adolgachev approved these changes Sep 25, 2025
adolgachev removed the action: review adolgachev added presubmit failures 
| Has a fair number of internal tests breaking, but will take a look at handling those and merging over the next week or so. Thanks! |
| Thanks for taking a look. Ping me if I can help in any way. |
adolgachev pushed a commit to adolgachev/components that referenced this pull request Oct 19, 2025
The material/divider component sets its color using the `border-top-color` but the material/menu component attempts to override this by setting the `color` property which causes any overrides to not get applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The material/divider component sets its color using the
border-top-colorbut the material/menu component attempts to override this by setting thecolorproperty which causes any overrides to not get applied.