fix(material/timepicker): adds default aria-label to timepicker toggle #30284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
essjay05 requested review from amysorto and andrewseguin and removed request for a team 
wagnermaciel added the dev-app preview 
| Deployed dev-app for fc37006 to: https://ng-dev-previews-comp--pr-angular-components-30284-dev-gnu2ezzl.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
crisbeto reviewed Jan 8, 2025
essjay05 force-pushed the add-timepicker-toggle-aria-labelledby branch from 2252c9a to c91c98a Compare essjay05 changed the title essjay05 force-pushed the add-timepicker-toggle-aria-labelledby branch from 1174e6d to 91fbc3e Compare 
| You'll need to update the api goldens. I believe this is the command: |
angular-robot bot added the area: build & ci essjay05 force-pushed the add-timepicker-toggle-aria-labelledby branch from 658d59c to fd5f7ab Compare crisbeto reviewed Jan 9, 2025
essjay05 force-pushed the add-timepicker-toggle-aria-labelledby branch from 2ceb536 to 1064b5f Compare essjay05 force-pushed the add-timepicker-toggle-aria-labelledby branch from 1064b5f to aa98fb6 Compare 
Updates Angular Component Timepicker so the timepicker toggle uses the aria-labelledby value for the timepicker toggle button to make it more accessible. Fixes b/380308482
Updates Angular Components Timepicker component by creating a default aria-label to the timepicker toggle if one is not supplied. This makes the button more accessible and descriptive for screen readers. Fix b/380308482
Updates previous fix to fix lint error.
Ran command to update api goldens.
…rride Updates previous fix which implements a default aria-label if no custom aria-label is provided to where it checks if an aria-lablledby value is provided and uses the aria-labelledby value if available. If not it will check for a custom aria-label and if that is not provided it will default to the generic aria-label value.
essjay05 force-pushed the add-timepicker-toggle-aria-labelledby branch from aa98fb6 to fc37006 Compare 
andrewseguin approved these changes Jan 15, 2025
andrewseguin added the target: patch 
| This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updates Angular Component Timepicker so the timepicker toggle has a default aria-label value if no aria-label is applied for the timepicker toggle button to make it more accessible. Also adds additional option of applying aria-labelledby to Timepicker toggle button.
Before screencast
After screencast
Fixes b/380308482