Skip to content

fix(material/theming): fix not found error in the guide duplicate theming styles document #30108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(material/theming): fix not found error in the guide duplicate theming styles document #30108

merged 1 commit into from
Dec 16, 2024

Conversation

Sepandard
Copy link
Contributor

@Sepandard Sepandard commented Nov 30, 2024 •
edited
Loading

pointing to the v18 version of the document
resolves #30072
@Sepandard Sepandard requested a review from a team as a code owner November 30, 2024 11:34
@Sepandard Sepandard requested review from crisbeto and mmalerba and removed request for a team November 30, 2024 11:34
@angular-robot angular-robot bot added the area: docs Related to the documentation label Nov 30, 2024
@Sepandard Sepandard force-pushed the fix-duplicate-theming-guides-docs branch from a276ad1 to 08bc8e9 Compare November 30, 2024 12:44
@angular-robot angular-robot bot removed the area: docs Related to the documentation label Nov 30, 2024
@Sepandard Sepandard changed the title fix(docs): fix not found error in the guide duplicate theming styles document fix(material/theming): fix not found error in the guide duplicate theming styles document Nov 30, 2024
@crisbeto crisbeto requested a review from andrewseguin December 2, 2024 13:19
@andrewseguin
Copy link
Contributor

Thanks for this contribution, however rather than bringing the guide back, it would be better to point to the v18 version of the doc instead: https://v18.material.angular.io/guide/duplicate-theming-styles
@andrewseguin andrewseguin self-assigned this Dec 4, 2024
@Sepandard Sepandard force-pushed the fix-duplicate-theming-guides-docs branch from 08bc8e9 to 08906ec Compare December 15, 2024 11:57
@Sepandard
fix(material/theming): fix not found error in the guide duplicate the…
6f2158f 
…ming styles document point to the v18 version of the document resolves angular#30072
@Sepandard Sepandard force-pushed the fix-duplicate-theming-guides-docs branch from 08906ec to 6f2158f Compare December 15, 2024 11:57
@Sepandard
Copy link
Contributor Author

Based on your comment, I changed the warning message, pointing to the v18 version document.
@andrewseguin
@andrewseguin
Copy link
Contributor

Great thanks!
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Dec 16, 2024
@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Dec 16, 2024
@andrewseguin andrewseguin merged commit b924e86 into angular:main Dec 16, 2024
22 of 24 checks passed
andrewseguin pushed a commit that referenced this pull request Dec 16, 2024
@Sepandard @andrewseguin
fix(material/theming): fix not found error in the guide duplicate the…
125d867 
…ming styles document (#30108) point to the v18 version of the document resolves #30072 (cherry picked from commit b924e86)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

2 participants

@Sepandard @andrewseguin