Skip to content

feat(common): Support of optional keys for the KeyValue pipe #48814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(common): Support of optional keys for the KeyValue pipe #48814

wants to merge 1 commit into from
+62 −0

Conversation

JeanMeche
Copy link
Member

This commit is extending the capabilities of the KeyValue pipe by allowing interfaces with optional keys.

fixes #46867

PR Type

What kind of change does this PR introduce?

  • Feature

Does this PR introduce a breaking change?

  • No
@JeanMeche JeanMeche force-pushed the feature/keyvalue-obj branch from 3814e04 to f4571bb Compare January 23, 2023 20:48
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jan 23, 2023
bougwal
bougwal reviewed Jan 23, 2023
View reviewed changes
dylhunn
dylhunn reviewed Jan 24, 2023
View reviewed changes
@dylhunn dylhunn added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: common Issues related to APIs in the @angular/common package core: pipes target: minor This PR is targeted for the next minor release labels Jan 24, 2023
@ngbot ngbot bot modified the milestone: Backlog Jan 24, 2023
@JeanMeche JeanMeche force-pushed the feature/keyvalue-obj branch from f4571bb to 3077721 Compare February 3, 2023 13:53
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 13, 2023
@JeanMeche JeanMeche force-pushed the feature/keyvalue-obj branch from 3077721 to 6046018 Compare January 31, 2024 15:53
jessicajaniuk
jessicajaniuk approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

reviewed-for: fw-common, public-api
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 31, 2024
@jessicajaniuk jessicajaniuk removed their request for review January 31, 2024 15:57
@pullapprove pullapprove bot requested a review from dylhunn January 31, 2024 15:57
@AndrewKushnir AndrewKushnir changed the title feature(common): Support of optional keys for the KeyValue pipe feat(common): Support of optional keys for the KeyValue pipe Jan 31, 2024
@jessicajaniuk
Copy link
Contributor

@JeanMeche There's a little lack of clarity on the types union here and how it solves the problem. Can you add some documentation on it to clarify how it solves the problem so it's easier for reviewers?
@jessicajaniuk jessicajaniuk removed the action: merge The PR is ready for merge by the caretaker label Jan 31, 2024
thePunderWoman
thePunderWoman approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment •
edited by JeanMeche
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api
LGTM
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Sep 30, 2025
@kirjs
Copy link
Contributor

kirjs commented Oct 1, 2025

This PR was merged into the repository. The changes were merged into the following branches:
@kirjs kirjs closed this in 99c5269 Oct 1, 2025
@JeanMeche JeanMeche reopened this Oct 1, 2025
@JeanMeche
Copy link
Member Author

PR as reverted by #64179 for being breaking.
@JeanMeche JeanMeche force-pushed the feature/keyvalue-obj branch 2 times, most recently from 4e8bb2d to b2cd70a Compare October 1, 2025 22:02
@JeanMeche
feat(common): Support of optional keys for the KeyValue pipe
6cfe45c 
This commit is extending the capabilities of the KeyValue pipe by allowing interfaces with optional keys. fixes angular#46867
@JeanMeche JeanMeche force-pushed the feature/keyvalue-obj branch from b2cd70a to 6cfe45c Compare October 1, 2025 22:19
@JeanMeche JeanMeche added action: global presubmit The PR is in need of a google3 global presubmit action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker action: global presubmit The PR is in need of a google3 global presubmit labels Oct 1, 2025
@JeanMeche
Copy link
Member Author

TGP is green.
@mmalerba
Copy link
Contributor

mmalerba commented Oct 2, 2025

This PR was merged into the repository. The changes were merged into the following branches:
@mmalerba mmalerba closed this in 9eac43c Oct 2, 2025
napulitanfrontend pushed a commit to napulitanfrontend/angular that referenced this pull request Oct 10, 2025
@JeanMeche
feat(common): Support of optional keys for the KeyValue pipe (angular…
cb5ffb6 
…#48814) This commit is extending the capabilities of the KeyValue pipe by allowing interfaces with optional keys. fixes angular#46867 PR Close angular#48814
napulitanfrontend pushed a commit to napulitanfrontend/angular that referenced this pull request Oct 10, 2025
@JeanMeche
feat(common): Support of optional keys for the KeyValue pipe (angular…
d1b9516 
…#48814) This commit is extending the capabilities of the KeyValue pipe by allowing interfaces with optional keys. fixes angular#46867 PR Close angular#48814
napulitanfrontend pushed a commit to napulitanfrontend/angular that referenced this pull request Oct 11, 2025
@JeanMeche
feat(common): Support of optional keys for the KeyValue pipe (angular…
876f7cb 
…#48814) This commit is extending the capabilities of the KeyValue pipe by allowing interfaces with optional keys. fixes angular#46867 PR Close angular#48814
napulitanfrontend pushed a commit to napulitanfrontend/angular that referenced this pull request Oct 11, 2025
@JeanMeche
feat(common): Support of optional keys for the KeyValue pipe (angular…
53b77dd 
…#48814) This commit is extending the capabilities of the KeyValue pipe by allowing interfaces with optional keys. fixes angular#46867 PR Close angular#48814
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package core: pipes detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

9 participants

@JeanMeche @jessicajaniuk @kirjs @mmalerba @thePunderWoman @dylhunn @bougwal @deolrup-bh @pkozlowski-opensource