Skip to content

Conversation

ClaraMuller
Copy link
Contributor

@ClaraMuller ClaraMuller commented Sep 9, 2025

🧭 What and Why

Merge composition-full into composition

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-487

Changes included:

  • Specs
rm -rf specs/composition mv specs/composition-full specs/composition 
  • Tests
rm -rf tests/CTS/client/composition mv tests/CTS/client/composition-full tests/CTS/client/composition 
  • Update of file config/clients.config.json

And small adjustments.

🧪 Test

CI

@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 9, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 43f1401631acd8237c0004bb62a9d49b0076bb52
🍃 Generated commit 9876bc7432245234069211ec1528c3cefc699cad
🌲 Generated branch generated/clara/feat/merge-comp-api-clients
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1700
javascript 1654
php 1503
csharp 1257
python 1179
java 1002
ruby 813
swift 679
scala 23
Base automatically changed from clara/refact/path-name to main September 11, 2025 08:01
@ClaraMuller ClaraMuller force-pushed the clara/feat/merge-comp-api-clients branch 2 times, most recently from 2db4354 to 985d4e9 Compare September 11, 2025 12:01
@ClaraMuller ClaraMuller force-pushed the clara/feat/merge-comp-api-clients branch from 985d4e9 to 5975011 Compare September 15, 2025 12:46
@ClaraMuller ClaraMuller marked this pull request as ready for review September 15, 2025 12:56
@ClaraMuller ClaraMuller requested a review from a team as a code owner September 15, 2025 12:56
@ClaraMuller ClaraMuller requested review from a team, millotp and shortcuts September 15, 2025 12:56
@millotp millotp force-pushed the clara/feat/merge-comp-api-clients branch from d6985eb to 1ab39e2 Compare September 15, 2025 13:27
@shortcuts
Copy link
Member

i've commented some endpoints in the spec.yml file which seems to lead to infinite path linking, we will take a closer look tomorrow!

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed every file changed

@millotp millotp merged commit 9884be6 into main Sep 19, 2025
29 checks passed
@millotp millotp deleted the clara/feat/merge-comp-api-clients branch September 19, 2025 12:11
algolia-bot added a commit that referenced this pull request Sep 19, 2025
…ted) [skip ci] Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Sep 19, 2025
algolia/api-clients-automation#5333 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Sep 19, 2025
algolia/api-clients-automation#5333 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Sep 19, 2025
algolia/api-clients-automation#5333 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Sep 19, 2025
algolia/api-clients-automation#5333 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 19, 2025
algolia/api-clients-automation#5333 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Sep 19, 2025
algolia/api-clients-automation#5333 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Sep 19, 2025
algolia/api-clients-automation#5333 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Sep 19, 2025
algolia/api-clients-automation#5333 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Sep 19, 2025
algolia/api-clients-automation#5333 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Sep 19, 2025
algolia/api-clients-automation#5333 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Sep 19, 2025
algolia/api-clients-automation#5333 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants