Skip to content

Conversation

bengreenbank
Copy link
Contributor

🧭 What and Why

Change the auth mode to default to header auth for the JS advanced perso client, due to query param based auth being disallowed in the API.

🎟 JIRA Ticket: none

Changes included:

  • Change templates

🧪 Test

n/a

@bengreenbank bengreenbank requested a review from a team as a code owner July 8, 2025 08:56
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 8, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 6e1e531f6ec8ee7e386e280ecabc2a3c4ed32f5b
🍃 Generated commit 2c8ceb8d4d0785cc14df757029415f884a0aa98e
🌲 Generated branch generated/feat/adv-perso/force-header-auth-js
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1666
shortcuts
shortcuts previously approved these changes Jul 8, 2025
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@bengreenbank bengreenbank changed the title templates: use headers in js advanced perso client feat(templates): use headers in js advanced perso client Jul 8, 2025
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@shortcuts shortcuts merged commit 6a90357 into main Jul 8, 2025
13 checks passed
@shortcuts shortcuts deleted the feat/adv-perso/force-header-auth-js branch July 8, 2025 09:23
algolia-bot added a commit that referenced this pull request Jul 8, 2025
…erated) [skip ci] Co-authored-by: Ben Greenbank <61185468+bengreenbank@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 8, 2025
algolia/api-clients-automation#5083 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Greenbank <61185468+bengreenbank@users.noreply.github.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants