Fix errors when scanning METADATA.bzl

[vasily-pozdnyakov]

Fixes #4206

Tasks

• Reviewed contribution guidelines
• PR is descriptively titled 📑 and links the original issue above 🔗
• Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  Run tests locally to check for errors.
• Commits are in uniquely-named feature branch and has no merge conflicts 📁

[AyanSinhaMahapatra]

Thanks a lot for detecting this and providing the fix @vasily-pozdnyakov we seem to have missed this when we moved to a different package assembly process and model here.

We were only testing the package data parsing here, but not the package assembly here (which is where assign_package_to_resources is called) hence the miss.
Do you mind also adding a test similarly like

scancode-toolkit/tests/packagedcode/test_build.py

Line 27 in 4b57a7f

def test_end2end_scan_can_detect_bazel(self):

like the following:

def test_end2end_scan_can_detect_bazel(self): test_file = self.get_test_loc('metadatabzl/new-format/METADATA.bzl') expected_file = self.get_test_loc('metadatabzl/new-format/metadatabzl-expected.json') result_file = self.get_temp_file('results.json') run_scan_click(['--package', test_file, '--json-pp', result_file]) check_json_scan(expected_file, result_file, regen=REGEN_TEST_FIXTURES) 

You also have to create the test file at tests/packagedcode/data/build/metadatabzl/new-format/metadatabzl-expected.json and regen this newly added test to populate this.

[vasily-pozdnyakov]

@AyanSinhaMahapatra
I added a test, as you proposed. Unfortunately I get an error locally, the problem is probably here:
https://github.com/aboutcode-org/scancode-toolkit/blob/4b57a7fe86e60e14694445a63f379b22ecbd7135/src/packagedcode/build.py#L270C6-L270C7

[mstykow]

@AyanSinhaMahapatra how can we move this forward?