Fix lispy-backward-kill-word delimiter-balancing #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* lispy.el (lispy-backward-kill-word): When looking back at ") ", we would take the first if's then branch because the char before is whitespace. However, this branch would call backward-kill-word which doesn't skip over delimiters. Prevent this situation by taking the then branch only if we're looking back at a word or symbol constituent followed by whitespace, in which case backward-kill-word behaves correctly. If we're not looking back at such a pattern, we end up in the else branch, which does skip over delimiters. Fixes abo-abo#584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
would take the first if's then branch because the char before is
whitespace. However, this branch would call backward-kill-word which
doesn't skip over delimiters. Prevent this situation by taking the then
branch only if we're looking back at a word or symbol constituent
followed by whitespace, in which case backward-kill-word behaves
correctly. If we're not looking back at such a pattern, we end up in the
else branch, which does skip over delimiters.
Fixes #584