Progress prints an empty line after finishing in jupyter #2616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cceyda changed the title 
alexisthual approved these changes Mar 8, 2023
cceyda force-pushed the progress_jupyter_fix branch from 2ff104e to 2eb5cbf Compare 5 tasks
| @alexisthual I accidently closed the PR during main sync, reopened here #2867 |
| No worries, let's jump there! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
More of a cosmetic fix than a bugfix, but the extra lines were just not fun to look at.
In notebooks 2 extra empty lines were printed after the progress bar finished (where
console.is_jupyter) as seen below:It is even more visible in vs-code:
There is still one empty line being printed at the end, but I suspect that maybe a well known
ipywidgetsproblem. ref: jupyter-widgets/ipywidgets#2880tested it manually 👀 in vs-code(latest: 1.72.2), jupyterlab, and google colab(it was never printing empty lines)