-
- Notifications
You must be signed in to change notification settings - Fork 81
docs: Add custom widget and action documentation. #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRemoved two legacy concept pages and added two new concept guides; updated the docs navigation to reference the new pages. No code or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🪛 LanguageTooldocs/concepts/custom_widgets.mdx[grammar] ~226-~226: Ensure spelling is correct (QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1) 🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/concepts/custom_actions.mdx (1)
180-207: Verify converter documentation completeness.The DoubleConverter is documented, but line 184 mentions converters are similar to widgets. Ensure this section documents all relevant converters applicable to actions with consistency to the custom_widgets documentation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
docs/concepts/action_parsers.mdx(0 hunks)docs/concepts/custom_actions.mdx(1 hunks)docs/concepts/custom_widgets.mdx(1 hunks)docs/concepts/parsers.mdx(0 hunks)docs/docs.json(1 hunks)
💤 Files with no reviewable changes (2)
- docs/concepts/parsers.mdx
- docs/concepts/action_parsers.mdx
🧰 Additional context used
🪛 LanguageTool
docs/concepts/custom_widgets.mdx
[grammar] ~226-~226: Ensure spelling is correct
Context: ..... fromJson and toJson } ``` ### Using Stac Types Prefer Stac types over primitive...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🔇 Additional comments (4)
docs/docs.json (1)
36-43: Navigation updates are correctly configured.The Concepts group now references the new custom widgets and actions documentation. The structure aligns with the new documentation files.
docs/concepts/custom_actions.mdx (1)
36-63: Excellent code examples and clear documentation structure.The step-by-step guide with accompanying code examples is well-organized and easy to follow. Examples correctly demonstrate class definition, JSON serialization, parser implementation, and usage patterns.
Also applies to: 138-161, 211-250
docs/concepts/custom_widgets.mdx (2)
36-65: Code examples and documentation structure are excellent.The step-by-step guide with accompanying code examples is comprehensive and well-organized. Examples correctly demonstrate widget class definition, JSON serialization, parser implementation, and usage patterns. The progression from basic to advanced patterns is logical and helpful.
Also applies to: 129-156, 249-293
174-245: Advanced patterns and type guidance are well-documented.The advanced patterns section comprehensively covers both DoubleConverter and StacWidgetConverter with clear examples. The "Using Stac Types" section provides valuable guidance for maintaining consistency and best practices when building custom widgets.
Description
Add custom widget and action documentation.
Type of Change
Summary by CodeRabbit