Skip to content

Conversation

pallavigitwork
Copy link
Member

@pallavigitwork pallavigitwork commented Aug 13, 2025

User description

i believe instead of easy, we mark good first issue, so changed that.

🔗 Related Issues

💥 What does this PR do?

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Bug fix (backwards compatible)
  • New feature (non-breaking change which adds functionality and tests!)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Type

Documentation


Description

  • Update CONTRIBUTING.md to reference "good first issue" label

  • Replace outdated "E-easy" label reference with current GitHub standard


Diagram Walkthrough

flowchart LR A["CONTRIBUTING.md"] -- "update label reference" --> B["good first issue"] 
Loading

File Walkthrough

Relevant files
Documentation
CONTRIBUTING.md
Update issue label reference                                                         

CONTRIBUTING.md

  • Updated link text from "E-easy" to "good first issue"
  • Modified GitHub issue search URL to use new label format
+1/-1     

i believe instead of easy, we mark good first issue, so changed that.
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

5678 - Partially compliant

Compliant requirements:

  • None

Non-compliant requirements:

  • Investigate and resolve ChromeDriver "ConnectFailure" errors
  • Reproduce and validate across multiple instances
  • Address environment/version-specific behavior

Requires further human verification:

  • Reproduction of the issue in the specified environment
  • Runtime validation across multiple ChromeDriver instances

1234 - Partially compliant

Compliant requirements:

  • None

Non-compliant requirements:

  • Restore click() behavior triggering JS in link href
  • Validate on specified Firefox version and environment
  • Add regression test

Requires further human verification:

  • Browser-specific manual testing on Firefox 42 environment
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Link Accuracy

Verify that the GitHub search URL correctly filters issues by the "good first issue" label and matches current repository labeling conventions.

[issues labelled good first issue](https://github.com/SeleniumHQ/selenium/issues?q=is%3Aopen%20is%3Aissue%20label%3A%22good%20first%20issue%22) on Github.
Copy link
Contributor

qodo-merge-pro bot commented Aug 13, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Search both current and legacy labels

Include both legacy and current labels in the search to avoid missing older
issues still tagged with the previous label. This ensures the link remains
useful across label transitions.

CONTRIBUTING.md [60]

-[issues labelled good first issue](https://github.com/SeleniumHQ/selenium/issues?q=is%3Aopen%20is%3Aissue%20label%3A%22good%20first%20issue%22) +[issues labelled `good first issue`](https://github.com/SeleniumHQ/selenium/issues?q=is%3Aopen%20is%3Aissue%20is%3Aopen%20label%3A%22good%20first%20issue%22%2C%22E-easy%22)
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: This suggestion correctly points out that searching for both the old (E-easy) and new (good first issue) labels would provide a more comprehensive list for new contributors, improving the link's utility.

Medium
Clarify label formatting
Suggestion Impact:The commit updated the link text to include backticks around the label name, aligning with the suggestion (with a minor addition of a colon).

code diff:

-[issues labelled good first issue](https://github.com/SeleniumHQ/selenium/issues?q=is%3Aopen%20is%3Aissue%20label%3A%22good%20first%20issue%22) +[issues labelled: `good first issue`](https://github.com/SeleniumHQ/selenium/issues?q=is%3Aopen%20is%3Aissue%20label%3A%22good%20first%20issue%22)

Use backticks around the label name in the link text to match GitHub’s UI and
avoid ambiguity. This also helps distinguish the label from surrounding prose.

CONTRIBUTING.md [60]

-[issues labelled good first issue](https://github.com/SeleniumHQ/selenium/issues?q=is%3Aopen%20is%3Aissue%20label%3A%22good%20first%20issue%22) +[issues labelled `good first issue`](https://github.com/SeleniumHQ/selenium/issues?q=is%3Aopen%20is%3Aissue%20label%3A%22good%20first%20issue%22)

[Suggestion processed]

Suggestion importance[1-10]: 3

__

Why: This is a minor stylistic suggestion that improves readability by using backticks for the label name, which is a good practice.

Low
  • Update
Copy link
Member

@cgoldberg cgoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. thanks!

(I made a tiny update to your branch for readability)

@cgoldberg cgoldberg changed the title Update CONTRIBUTING.md Update issue label in CONTRIBUTING.md Aug 13, 2025
@cgoldberg cgoldberg changed the title Update issue label in CONTRIBUTING.md [docs] Update issue label in CONTRIBUTING.md Aug 13, 2025
@cgoldberg cgoldberg merged commit 1d8078e into SeleniumHQ:trunk Aug 13, 2025
9 checks passed
@pallavigitwork
Copy link
Member Author

Thank you @cgoldberg

@pallavigitwork pallavigitwork deleted the patch-2 branch September 8, 2025 10:39
This was referenced Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants