Skip to content

[py] Fix path in unit test so it works cross-platform #16033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2025
Merged

[py] Fix path in unit test so it works cross-platform #16033

merged 4 commits into from
Jul 10, 2025

Conversation

cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented Jul 9, 2025 •
edited
Loading

💥 What does this PR do?

This PR fixes the test_get_connection_manager_for_certs_and_timeout test. It was failing on Windows due to a hardcoded path separator.

🔄 Types of changes

  • Unit tests
  • Bug fix (backwards compatible)
Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •
    @selenium-ci selenium-ci added the C-py Python Bindings label Jul 9, 2025
    @qodo-merge-pro Qodo Merge Pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 9, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected
    @SeleniumHQ SeleniumHQ deleted a comment from qodo-merge-pro bot Jul 9, 2025
    @cgoldberg cgoldberg merged commit db00a84 into SeleniumHQ:trunk Jul 10, 2025
    16 checks passed
    @cgoldberg cgoldberg deleted the py-fix-unit-test-cert-path branch July 10, 2025 13:15
    This was referenced Sep 12, 2025
    Closed
    Closed
    Merged
    This was referenced Sep 19, 2025
    Closed
    Closed
    Closed
    This was referenced Oct 1, 2025
    Closed
    Closed
    Closed
    Merged
    Closed
    Open
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    C-py Python Bindings Review effort 1/5

    2 participants

    @cgoldberg @selenium-ci