This repository was archived by the owner on Dec 3, 2022. It is now read-only.
Handle overflow cases #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There were overflow cases hidden in the encode and decode: 1. Encoding - Any number with the 31st bit set would be incorrect, because it used `>>` instead of `>>>`. So the 31st bit would be set to the 32nd (sign bit, making it negative). Then when we try to encode the number, we would that it's `num < 0` after the first iteration. 2. Decoding - The encoded representation of -2147483648 (smallest 32bit signed int) would return -0 - Any number with the 31st bit set would return the opposite sign, because it used `>>` instead of `>>>`.
Contributor Author
| The test failure here is due to |
Owner
| Yeah, looking at that right now |
Owner
| Released 1.4.5. Thank you |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There were overflow cases hidden in the encode and decode:
>>instead of>>>. So the 31st bit would be set to the 32nd (sign bit, making it negative). Then when we try to encode the number, we would that it'snum < 0after the first iteration.>>instead of>>>.