Use a definite version specification when depending on pyo3-build-config. #3721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…fig. We already do this for other internal pyo3-* dependencies and it seems prudent to apply this to pyo3-build-config as well.
CodSpeed Performance ReportMerging #3721 will improve performances by 11.66%Comparing Summary
Benchmarks breakdown
|
davidhewitt approved these changes Jan 2, 2024
Member
davidhewitt left a comment
davidhewitt left a comment There was a problem hiding this comment.
Agreed, shame it's too late to apply this to 0.20.0. I'm tempted to backport for 0.20.2 anyway.
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We already do this for other internal
pyo3-*dependencies and it seems prudent to apply this topyo3-build-configas well.Closes #3719