Skip to content

Select the parent of the script containing import.meta.document #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Select the parent of the script containing import.meta.document #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/html-module-transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const htmlModuleToJsModuleMap =

if (property.type === 'Identifier') {
Copy link
Contributor

@cdata cdata May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem here is that this check is not specific enough. The condition is checking for usages of import.meta.* as an expression, but isn't particular about import.meta.script (the original use case) vs import.meta.document.

We should probably change the condition to something like:

if (property.type === 'Identifier') { switch (property.name) { case 'script': // Do the current transform for script break; case 'document': // Do the new proposed transform for document break; } }
memberExpression.replaceWith(ast`($documentModule.querySelector(${
importMetaScriptElementSelector}))`);
importMetaScriptElementSelector}).parentElement)`);
}
}

Expand Down