Skip to content

Conversation

@kangguangli
Copy link
Contributor

@kangguangli kangguangli commented Mar 6, 2023

PR types

Others

PR changes

Others

Describe

The api with_data_parallel will be removed after paddle2.5. So its references should be removed at same time.
The with_data_parallel here has no effect since the place was or should be 1.

Others

Pcard-67004

@paddle-bot
Copy link

paddle-bot bot commented Mar 6, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@pangyoki pangyoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改的TracedLayer的代码,这个只支持旧版动态图了,后续也会下掉,LGTM

Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kangguangli kangguangli merged commit 2bd63c0 into PaddlePaddle:develop Mar 8, 2023
@kangguangli kangguangli deleted the remove_wdp_in_misc branch March 8, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants