Skip to content

Conversation

@qili93
Copy link
Contributor

@qili93 qili93 commented Jan 17, 2023

PR types

New features

PR changes

OPs

Describe

Zero-dim support of histogram kernel

@paddle-bot
Copy link

paddle-bot bot commented Jan 17, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

x = paddle.rand([])
out = paddle.histogram(x, bins=5, min=1, max=5)
self.assertEqual(out.shape, [5])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

histogram算子没有反向kernel的实现,因此这里不对反向输出shape做检查

@qili93 qili93 requested a review from zhwesky2010 January 17, 2023 10:26
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 6cd7fca into PaddlePaddle:develop Jan 18, 2023
@qili93 qili93 deleted the histogram_zero_dim branch January 18, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants