Skip to content

Conversation

@seemingwang
Copy link
Contributor

@seemingwang seemingwang commented Jan 5, 2023

PR types

Others

PR changes

Others

Describe

support zero-dimension input for embedding and one-hot api-

@zhwesky2010 zhwesky2010 changed the title Zero d 【Zero-Dim】Support Zero dim for embedding and one-hot Jan 5, 2023
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customdevice 与主repo case一致

x_dims.size(),
1,
phi::errors::InvalidArgument("Rank of Input(X) should be at least 1."));
// PADDLE_ENFORCE_GE(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改成>=0吧

x_dims.size(),
1,
phi::errors::InvalidArgument("Rank of Input(X) should be at least 1."));
// PADDLE_ENFORCE_GE(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改成>=0吧

zhwesky2010
zhwesky2010 previously approved these changes Jan 5, 2023
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemingwang seemingwang merged commit 370b50f into PaddlePaddle:develop Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants