[Eager] saved_tensors_hooks #45763
Merged
[Eager] saved_tensors_hooks #45763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010 reviewed Sep 6, 2022
| autograd_meta | ||
| hook_utils) | ||
| | ||
| cc_library( |
JiabinYang reviewed Sep 6, 2022
| std::function<void()> fn_; | ||
| }; | ||
| | ||
| class PackHookBase { |
Contributor Author
There was a problem hiding this comment.
你看一下。这里有两个Hook。给取两个名字吧。
| dense_tensor->meta()))); | ||
| auto pack_hook = SavedTensorsHooks::GetInstance().GetPackHook(); | ||
| unpack_hook_ = SavedTensorsHooks::GetInstance().GetUnPackHook(); | ||
| packed_value_ = reinterpret_cast<PyObject*>((*pack_hook)(tensor)); |
Contributor
There was a problem hiding this comment.
这个地方能用void* 嘛，这样是不是我们可以不依赖Python.h了
Contributor Author
There was a problem hiding this comment.
saved_tensors_hooks.h里的hook是PyObject*，所以这里是不是PyObject*都需要依赖Python.h。
Contributor
| LGTM |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
添加paddle.autograd.saved_tensors_hooks 模块