Skip to content

Conversation

@InAnYan
Copy link
Member

@InAnYan InAnYan commented Sep 13, 2025

Closes #11377

Added:

  • Transliteration field formatter.
  • Transliteration of citation keys.
  • Ability to turn off or on transliteration for citation keys.

Result:

2025-09-13_12-00

Steps to test

  • Enter author in Cyrillic script or Chinese language.
  • Turn on "Transliterate fields" (turned on by default).
  • Click "Generate key".

Results:

2025-09-13_11-49 2025-09-13_12-55

Mandatory checks

@InAnYan
Copy link
Member Author

InAnYan commented Sep 13, 2025

I expect that I chose some wrong naming or placement

@InAnYan
Copy link
Member Author

InAnYan commented Sep 16, 2025

Sorry, forgot a bit about this PR

@Siedlerchr
Copy link
Member

It would be nice to have this finished, seems like you just need to adjust the mocks/options in the test?

@InAnYan
Copy link
Member Author

InAnYan commented Sep 22, 2025 via email

}

private static String buildTransliteratorConfig() {
StringBuilder pattern = new StringBuilder();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using StringBuilder for simple string concatenation can be replaced with StringJoiner for better readability and maintainability.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really?

@jabref-machine
Copy link
Collaborator

While the PR was in progress, a new version of JabRef has been released.

You have to merge upstream/main and move your entry in CHANGELOG.md up to the section ## [Unreleased].

@InAnYan
Copy link
Member Author

InAnYan commented Nov 6, 2025

Ready to review

@InAnYan InAnYan added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: citationkey-generator project: jabcon status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

4 participants