Use faas.instance instead of faas.id in resource detection and mapping #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dashpole force-pushed the fix_faas_instance branch from 94077e7 to f43b9b8 Compare 
Contributor Author
| Just the basic trace scenario is failing, which shouldn't be impacted by this PR. Resource detection passes |
aabmass approved these changes Aug 14, 2023
dashpole added a commit to dashpole/opentelemetry-operations-java that referenced this pull request Nov 15, 2023
…d mapping (GoogleCloudPlatform#260)" This reverts commit 4ecc4f4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Context: GoogleCloudPlatform/opentelemetry-operations-go#679
This also bumps the e2e test image to pick up the validation for faas.instance.