Added the ability to delete a datasource #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
(not yet functional) edit button
but I don't know why it works. It still doesn't affect storage, so deleting a data source is only until the page is reloaded.
I now underestand how it works.
Roey7 reviewed Mar 27, 2023
| } | ||
| } | ||
| | ||
| // let editMode = false; |
Roey7 reviewed Mar 27, 2023
| render() { | ||
| return ( | ||
| <div className="relative flex flex-col bg-[#221f2e] items-start px-8 pt-0 pb-4 min-h-[300px]"> | ||
| <div className="relative flex flex-col bg-[#221f2e] items-start px-8 pt-0 pb-4 min-h-[300px]">1 |
Roey7 reviewed Mar 27, 2023
| <IoMdClose onClick={this.props.onClose} className='absolute right-4 top-3 text-2xl text-white hover:text-[#9875d4] hover:cursor-pointer'></IoMdClose> | ||
| | ||
| {/* X and Edit in top right */} | ||
| <div className="absolute flex flex-col items-center right-4 top-3 text-2xl text-white gap-4"> |
There was a problem hiding this comment.
Move the edit button to be in the same line with the title, and make it bigger + a little margin right
Roey7 reviewed Mar 27, 2023
| !this.state.isAdding && ( | ||
| <div> | ||
| <h1 className="text-2xl block text-white mb-4"> | ||
| {/* h1 tag specifies whether there are active data sources */} |
Roey7 reviewed Mar 27, 2023
| <div className="flex py-2 pl-5 pr-3 m-2 flex-row items-center justify-center bg-[#352C45] hover:shadow-inner shadow-blue-500/50 rounded-lg font-poppins leading-[28px] border-b-[#916CCD] border-b-2"> | ||
| <img alt="data-source" className={"mr-2 h-[20px]"} src={this.props.dataSourceTypesDict[data_source].image_base64}></img> | ||
| <h1 className="text-white">{this.props.dataSourceTypesDict[data_source].display_name}</h1> | ||
| <AiFillCheckCircle className="ml-6 text-[#9875d4] text-2xl"> </AiFillCheckCircle> |
There was a problem hiding this comment.
do like that:
{ if(this.state.isEditMode) { return ...your_delete_thingy.... } else { return <AiFillCheckCircle className="ml-6 text-[#9875d4] text-2xl"> </AiFillCheckCircle> } } Roey7 reviewed Mar 27, 2023
Roey7 reviewed Mar 27, 2023
| } | ||
| } | ||
| } | ||
| |
There was a problem hiding this comment.
On edit mode, show only the connected data sources
hide inactive sources in edit mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As of now it isn't connected to the back-end, so deleting things isn't saved.
