Skip to content

Task queue #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 27, 2023
Merged

Task queue #60

merged 16 commits into from
Mar 27, 2023

Conversation

@Roey7
Copy link
Contributor

@Roey7 Roey7 commented Mar 26, 2023

No description provided.

@Roey7 Roey7 mentioned this pull request Mar 26, 2023
Closed
@Itaykal
Copy link
Contributor

Itaykal commented Mar 27, 2023

I think it would be safer for the data_source API to stay in a separate folder from the sources.
Another option is to create app/data_source/data_source_api or app/data_source/data_source_sdk
but leaving it as files in the data_source folder could lead to issues when trying to expand the api/sdk whatever you want to call it
bary12
bary12 reviewed Mar 27, 2023
View reviewed changes
app/slaves.py Outdated

@classmethod
def start(cls):
for i in range(0, 20):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • make this a constant, also remove the 0
@Roey7 Roey7 merged commit 964e859 into main Mar 27, 2023
@Roey7 Roey7 deleted the task-queue branch March 27, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@Roey7 @Itaykal @bary12