Fix issu in gpt-5*, o1*, and o3* models as not supporting stop to avoid 400 Unsupported parameter errors. #5227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…pt-5-nano) Detect whether a model supports the `stop` parameter and only bind stop sequences when supported. Prevents 400 errors from models that reject `stop`. Files touched: ConversationalAgent, agents utils, XMLAgent (conditional stop binding).
| The latest version should already fixed that, see here |
| This bugfix is related to the unsupported 'stop' message for all gpt-5*, o1*, and o3* models. This is the issue in the main branch: this is from my curent branch |
HenryHengZJ reviewed Sep 18, 2025
| } from 'langchain/agents' | ||
| import { formatLogToString } from 'langchain/agents/format_scratchpad/log' | ||
| import { IUsedTool } from './Interface' | ||
| import { modelSupportsStop } from './utils' |
There was a problem hiding this comment.
where does this come from? I dont see any changes in utils file?
There was a problem hiding this comment.
I added the changes from the utils.ts file. Please check. Thanks
| Or, can you try using AgentflowV2? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix(agents): avoid sending unsupported 'stop' param to models (e.g. gpt-5-nano)
Detect whether a model supports the
stopparameter and only bind stop sequences when supported. Prevents 400 errors from models that rejectstop. Files touched: ConversationalAgent, agents utils, XMLAgent (conditional stop binding).