fix: add Redis connection resilience settings to prevent infinite hangs #5219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Add Redis timeout and retry configuration via environment variables - Fix waitUntilFinished() hanging indefinitely on Redis connection drops - Add connectTimeout, commandTimeout, maxRetriesPerRequest settings - Maintain backward compatibility with existing Redis env vars - Resolves issue FlowiseAI#5126 Breaking change: None
HenryHengZJ reviewed Sep 28, 2025
HenryHengZJ reviewed Oct 1, 2025
| const QUEUE_NAME = process.env.QUEUE_NAME || 'flowise-queue' | ||
| | ||
| // Redis resilience configuration with environment variable support | ||
| const REDIS_CONNECT_TIMEOUT = process.env.REDIS_CONNECT_TIMEOUT ? parseInt(process.env.REDIS_CONNECT_TIMEOUT, 10) : 10000 |
There was a problem hiding this comment.
I prefer not to hardcode a default value for these.
If these are set, we only pass it in, if not, we leave it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #5126 - Flowise hangs indefinitely when Redis connections drop, causing
ECONNRESETerrors during queue processing.Solution
Adds Redis connection resilience configuration via environment variables:
REDIS_CONNECT_TIMEOUT=10000- Connection timeout (ms)REDIS_COMMAND_TIMEOUT=30000- Command timeout (ms) - prevents waitUntilFinished() hangingREDIS_MAX_RETRIES_PER_REQUEST=3- Retry attemptsREDIS_LAZY_CONNECT=true- Connect on demandREDIS_KEEPALIVE_INTERVAL=30000- Keep-alive interval (ms)Key Changes
packages/server/src/queue/QueueManager.tswith IORedis timeout/retry settingspackages/server/.env.examplewith new Redis configuration optionsTesting
pnpm build