Skip to content

Conversation

@mvanbeusekom
Copy link
Member

@mvanbeusekom mvanbeusekom commented Jun 6, 2023

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

Current CI configuration uses the flutter format command which has been deprecated by Google causing the builds to fail.

🆕 What is the new behavior (if this is a feature change)?

Updates the configuration to use the dart format instead as recommended by the Google Flutter team.

Note: this PR also adds a the new no-response.yaml workflow which will automatically close issues with the "status: needs more info" label after 14 days.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

CI build should now pass the formatting step.

📝 Links to relevant issues/docs

Resolves #152

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current main.
Copy link
Contributor

@JeroenWeener JeroenWeener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bar some small nits

mvanbeusekom and others added 3 commits June 6, 2023 12:14
Co-authored-by: Jeroen Weener <JeroenWeener@users.noreply.github.com>
Co-authored-by: Jeroen Weener <JeroenWeener@users.noreply.github.com>
Co-authored-by: Jeroen Weener <JeroenWeener@users.noreply.github.com>
@mvanbeusekom mvanbeusekom merged commit 64b0c6a into main Jun 6, 2023
@mvanbeusekom mvanbeusekom deleted the bugfix/ci branch June 6, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants