This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Add glossary #31
Merged
Add glossary #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…bing the current architecture of the DeepL translation API.
added 5 commits November 4, 2021 16:37
…ader based authentication
| @EtienneDh Any objections? |
| Hello @Sasti and thanks for taking the time to review and work on this PR. I have no objections, I think it's a good move to refactor Deepl's features into their own classes 👍 I understand you had some problems with test fixtures as you wrote a method to clean up after each test ? Sorry about that, as the testDeleteGlossary method is run last, it should have kept the glossary associated with the api key empty. Thanks for your modifications |
| Hi @Sasti, since everything works now, can we finally delete the feature branch? |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.