#1094: Honoring updates to realm and proxy realm from ResponseFilter #1311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Sorry, I don't get what your changes are supposed to fix. Could you elaborate please? |
| This is an attempt at fixing issue #1094. I'm on vacation for the next week, but will try to add some tests and push up my changes after that. |
| @slandelle Actually, I was wondering, if I have random questions when working on this project, what would be the best way to get in contact with you? Are you on IRC, or Gitter? |
| @Diagoras I don't use Gitter, and am almost never connected on IRC. Best way is Gtalk (slandelle at gatling dot io). |
slandelle changed the title slandelle force-pushed the master branch 5 times, most recently from 9334a56 to 391b4d8 Compare slandelle force-pushed the master branch 5 times, most recently from 6ea11f4 to f8fab66 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I can add some tests around this if you want, just say the word.