Fix infinite disassembly loop in CallTracerModule's gen_blocks_calls function #3467
+9 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
saruman9 force-pushed the fix_call_tracer_module branch from e02ca28 to 71d1437 Compare 
Contributor Author
| During the investigation, I discovered that the same infinite disassembly loop issue also exists in the |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the
CallTracerModulewhere thegen_blocks_callsfunction would enter an infinite loop repeatedly disassembling the same code block, which prevented the collection of call traces.Checklist
./scripts/precommit.shand addressed all comments