WIP: Themes: Minimal working solarized dark theme (via #1175) #1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove unnecessary import. Capitalize colors, as they are constants. Add some colors, to include full Solarized palette (data needs confirmation). Add aliases to foreground/background colors for dark/light themes, to avoid using incorrect palette entries in those themes. NOTE: We could extract the duplicate entries further into other enums, as I suggested in zulip#1175, or as constants outside of the enum, but this works for now.
Adds solarized to complete themes tests; renames style name to pass tests. Updates colors to use capitalized names, and translate from specific names to aliases which enable clear use in the theme. Various color changes made to improve to basic level of legibility. Solarized removed from theme aliases (not an old theme). Fixes still required: - still uses colors from the light theme that it is not supposed to use - needs a lot of checking of colors for best consistency different bit-depths - visual inspection during regular usage, ie. selection of good colors per UI element - syntax highlighting section needs validation (may be greatly simplified)
This was referenced Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are currently 3 open PRs (#1300, #1175, #324) for solarized dark, so I've taken the most complete (#1175) and added extra commits such that this runs and is usable with current ZT.
In doing so, the extra commits address my outstanding concerns regarding #1175.
I'm going to close the other PRs, though they can still be referenced.
While this is broadly usable as it is, there are various factors that it'd be good to address before merging:
Compared to #1175, my update to use dark-theme aliases in the enum breaks the addition of BOLD to the colors, so we could explore an alternative to that, as discussed in my commit.
When building upon this PR (see tools/fetch-pull-request), please keep commits separate on top for comparison, at least initially, since there will be multiple authors.
Tested?