Skip to content

Conversation

@kingjuno
Copy link
Collaborator

@kingjuno kingjuno commented Sep 7, 2021

What does this PR do?
This adds a feature to copy code snippets as mentioned in #1123

copy_code_snippet

Work in progress
Tested?

  • Manually
  • Existing tests (adapted, if necessary)
  • New tests added (for any new behavior)
  • Passed linting & tests (each commit)
@zulipbot zulipbot added the size: XL [Automatic label added by zulipbot] label Sep 7, 2021
@neiljp
Copy link
Collaborator

neiljp commented Apr 24, 2022

@kingjuno Thanks for the work on this, I fell short of time to review sooner. Would you like to take this forward?

Rebased 2023-03-16 by neiljp.
@neiljp
Copy link
Collaborator

neiljp commented Mar 16, 2023

I just rebased this to remove conflicts and get it working minimally.

This would fix most of #1123.

For anyone taking this forward, this would benefit from fixing the linting issues, splitting the commits, and adding tests for separate parts that are built into the final version. That includes in the latter commits first just showing the code snippet in the message-info popup first, before then adding the action.

Please attribute kingjuno and this PR if you take this forward, but open your own based on this PR. Once a PR is merged we will then close related PRs, and possibly the original issue.

@neiljp neiljp added the missing feature: user A missing feature for all users, present in another Zulip client label Mar 16, 2023
@neiljp
Copy link
Collaborator

neiljp commented Mar 25, 2023

#1353 is the current successor to this PR.

@zulipbot
Copy link
Member

Heads up @kingjuno, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has conflicts missing feature: user A missing feature for all users, present in another Zulip client PR replaced by another PR size: XL [Automatic label added by zulipbot]

3 participants