text: Add and use proportionalLetterSpacing #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator Author
|
chrisbobbe force-pushed the pr-proportional-letter-spacing branch from a500b0b to bb5e0e9 Compare 
gnprice reviewed Apr 29, 2024
Member
gnprice left a comment
gnprice left a comment There was a problem hiding this comment.
Thanks! LGTM; one suggestion below. Please go ahead and merge when ready.
test/widgets/text_test.dart Outdated
| } | ||
| | ||
| // From trying the options on an iPhone 13 Pro running iOS 16.6.1: | ||
| const textScaleFactors = <double>[ |
Member
There was a problem hiding this comment.
In the tests, the `textScaleFactors` list is copied from emoji_reaction_test. Perhaps there's a convenient place to define it centrally. I think probably most convenient would be to put it at the top level of this file text_test.dart, and then emoji_reaction_test.dart can import from there.
It feels slightly messy to have one file be importing from another file that has its own main function; but it works fine, and it makes a low-fuss solution here.
This is now the natural thing to do for tooltipTheme, following recommendations in the upstream docs (thanks to my PR flutter/flutter#135879!) and doesn't need an explicit comment explaining it.
As Greg suggests: zulip#629 (comment)
To confirm that [TextStyle.letterSpacing] is taken literally as logical pixels, as its dartdoc suggests it is, I rendered the text "||" with an extreme [TextStyle.letterSpacing] value of 40. Then it was easy to see that the letter spacing -- the horizontal distance between the two "|" characters -- wasn't changing as I adjusted the text-size slider in my iPhone settings. In the tests, the `textScaleFactors` list is copied from emoji_reaction_test. Perhaps there's a convenient place to define it centrally.
…ant it The letter spacings in these pieces of text hasn't been responding to system font-size adjustments. Now they do. There might not be any other instances of this problem in the app, because we widely apply 0 for [TextStyle.letterSpacing] (since 0065954), and when we do that, it shouldn't matter whether zero is considered as logical pixels or as a proportion the surrounding text size.
chrisbobbe force-pushed the pr-proportional-letter-spacing branch from bb5e0e9 to 70ca30d Compare chrisbobbe added a commit that referenced this pull request Apr 30, 2024
As Greg suggests: #629 (comment)
Collaborator Author
| Thanks! Done. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This could be helpful for #548, but I'm sending it now so we can see if we like the logic and want to reuse it for that. It does make a small adjustment to some letter spacing, to better follow the user's device-level text size setting, so I'll post some screenshots.