driver: i2c: i2c_dw: clear block mode on init #98583
Open
+2 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Depending on the IP's `IC_TX_CMD_BLOCK_DEFAULT` parameter, we might have to clear the `TX_CMD_BLOCK` bit on init so that Master mode works. Signed-off-by: Yong Cong Sin <ycsin@meta.com> Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
ycsin force-pushed the pr/dw_i2c-fix_block_mode branch from 2c2b3e2 to cd6bd5b Compare 
|
keith-zephyr reviewed Nov 5, 2025
| uint32_t reg_base = get_regs(dev); | ||
| | ||
| clear_bit_enable_en(reg_base); | ||
| /* depending on the IP configuration, we may have to disable block mode in master mode */ |
There was a problem hiding this comment.
Please use the inclusive term.
https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html#rule-a-2-inclusive-language
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Depending on the IP's
IC_TX_CMD_BLOCK_DEFAULTparameter, we might have to clear theTX_CMD_BLOCKbit on init so that Master mode works.Fixes #98588