Skip to content

testsuite: coverage: use correct path to fnmatch.h #98339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

testsuite: coverage: use correct path to fnmatch.h #98339

merged 1 commit into from
Oct 28, 2025

Conversation

@cfriedt
Copy link
Member

@cfriedt cfriedt commented Oct 27, 2025 •
edited
Loading

The minimal libc does not include fnmatch.h in its default search path.

This causes an issue when running coverage in CI as shown here.

https://github.com/zephyrproject-rtos/zephyr/actions/runs/18839500380/job/53748166725

That would technically be fixed with #97855 as well.

Testing Done:

west twister -c -p qemu_x86/atom -s kernel.pending.minimallibc --coverage --coverage-tool gcovr ... Deleting output directory /Users/cfriedt/zephyrproject/zephyr/twister-out INFO - Using Ninja.. INFO - Zephyr version: v4.3.0-rc1-12-gec3bcd39307a INFO - Using 'zephyr' toolchain. INFO - Building initial testsuite list... INFO - Writing JSON report /Users/cfriedt/zephyrproject/zephyr/twister-out/testplan.json INFO - Adding tasks to the queue... INFO - Added initial list of jobs to queue INFO - Total complete: 1/ 1 100% built (not run): 0, filtered: 0, failed: 0, error: 0 INFO - 1 test scenarios (1 configurations) selected, 0 configurations filtered (0 by static filter, 0 at runtime). INFO - 1 of 1 executed test configurations passed (100.00%), 0 built (not run), 0 failed, 0 errored, with no warnings in 25.32 seconds. INFO - 3 of 3 executed test cases passed (100.00%) on 1 out of total 1259 platforms (0.08%). INFO - 1 test configurations executed on platforms, 0 test configurations were only built. INFO - HTML report generated: /Users/cfriedt/zephyrproject/zephyr/twister-out/coverage/index.html INFO - Saving reports... INFO - Writing JSON report /Users/cfriedt/zephyrproject/zephyr/twister-out/twister.json INFO - Writing xunit report /Users/cfriedt/zephyrproject/zephyr/twister-out/twister.xml... INFO - Writing xunit report /Users/cfriedt/zephyrproject/zephyr/twister-out/twister_report.xml... INFO - Run completed west twister -c -T tests/kernel/pending --coverage --coverage-tool gcovr Deleting output directory /home/cfriedt/zephyrproject/zephyr/twister-out INFO - Using Ninja.. INFO - Zephyr version: v4.2.0-7317-gad8e28bd2515 INFO - Using 'zephyr' toolchain. INFO - Selecting default platforms per testsuite scenario INFO - Building initial testsuite list... INFO - Writing JSON report /home/cfriedt/zephyrproject/zephyr/twister-out/testplan.json INFO - JOBS: 32 INFO - Adding tasks to the queue... INFO - Added initial list of jobs to queue INFO - Total complete: 72/ 72 100% built (not run): 0, filtered: 20, failed: 0, error: 0 INFO - 2 test scenarios (92 configurations) selected, 20 configurations filtered (20 by static filter, 0 at runtime). INFO - 72 of 72 executed test configurations passed (100.00%), 0 built (not run), 0 failed, 0 errored, with no warnings in 110.56 seconds. INFO - 216 of 216 executed test cases passed (100.00%) on 36 out of total 1259 platforms (2.86%). INFO - 72 test configurations executed on platforms, 0 test configurations were only built. INFO - HTML report generated: /home/cfriedt/zephyrproject/zephyr/twister-out/coverage/index.html INFO - Saving reports... INFO - Writing JSON report /home/cfriedt/zephyrproject/zephyr/twister-out/twister.json INFO - Writing xunit report /home/cfriedt/zephyrproject/zephyr/twister-out/twister.xml... INFO - Writing xunit report /home/cfriedt/zephyrproject/zephyr/twister-out/twister_report.xml... INFO - Run completed
@cfriedt
testsuite: coverage: use correct path to fnmatch.h
ad8e28b 
The minimal libc does not include `fnmatch.h` in its default search path. This causes an issue when running coverage in CI as shown here. https://github.com/zephyrproject-rtos/zephyr/actions/runs/18839500380/\ job/53748166725 That would technically be fixed with zephyrproject-rtos#97855 as well. Testing Done: ``` west twister -c -p qemu_x86/atom -s kernel.pending.minimallibc --coverage\ --coverage-tool gcovr ``` Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@cfriedt cfriedt marked this pull request as ready for review October 27, 2025 16:57
@zephyrbot zephyrbot added size: XS A PR changing only a single line of code area: Testsuite Testsuite labels Oct 27, 2025
@cfriedt cfriedt added the Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. label Oct 27, 2025
@nashif nashif added this to the v4.3.0 milestone Oct 27, 2025
@jhedberg jhedberg merged commit b6d45e1 into zephyrproject-rtos:main Oct 28, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Code Coverage area: Testsuite Testsuite Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. size: XS A PR changing only a single line of code

4 participants

@cfriedt @nashif @jhedberg @zephyrbot