drivers timer nrf_rtc: Fix dependency #97821
Open
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
8498c39 seems to have introduce an incorrect dependency which prevents the RTC timer from been built if any of the RTC's are enabled. It should only depend on the rtc1. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
| @anangl @nordicjm @nordic-krch if you agree with this fix, please set the |
|
zephyrbot added size: XS Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
8498c39 seems to have introduce an incorrect dependency which prevents the RTC timer from been built if any of the RTC's are enabled.
It should only depend on the rtc1.
This was first pinpointed by @anangl here: #97441 (review)
Note this is currently failing in main:
https://github.com/zephyrproject-rtos/zephyr/actions/runs/18593829491/job/53015430226?pr=97785
and can be repro'd w
cmake -GNinja -DBOARD=nrf52_bsim ../tests/drivers/counter/counter_basic_api/ && ninjaNote that for real HW targets, as their SOC kconfig files currently redefine the option to set the default,
https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/nordic/nrf52/Kconfig.defconfig#L11
all depends are OR'ed with SOC_SERIES_NRF5XX(=y) && SOC_FAMILY_NORDIC_NRF(=y), so they ones from this file are effectively ignored.
But for the simulated targets we do not override the dependencies in this way.
Once this is fixed in #97441 for real targets, these real targets fail also.