Skip to content

Revert https://github.com/zephyrproject-rtos/zephyr/pull/95226 #96567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2025
Merged

Revert https://github.com/zephyrproject-rtos/zephyr/pull/95226 #96567

merged 3 commits into from
Sep 25, 2025

Conversation

@fabiobaltieri
Copy link
Member

Broke few stuff in CI, both main and PR runs.
@fabiobaltieri
Revert "posix: switch to using posix_time.h and posix_signal.h"
a01a480 
This reverts commit 1eb5c97. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
@fabiobaltieri
Revert "posix: headers: create a more conformant posix_signal.h"
e925cfd 
This reverts commit 5287699. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
@fabiobaltieri
Revert "posix: headers: create a more conformant posix_time.h"
6d395f2 
This reverts commit 63abc20. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
@zephyrbot zephyrbot added area: Build System area: POSIX POSIX API Library area: C Library C Standard Library labels Sep 25, 2025
cfriedt
cfriedt previously requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking while I am in the car and until I have a chance to look at the issue.
@pdgendt pdgendt linked an issue Sep 25, 2025 that may be closed by this pull request
posix: Missing signal.h header file #96566
Closed
1 task
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
25 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@nashif nashif added the Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. label Sep 25, 2025
@cfriedt
Copy link
Member

cfriedt commented Sep 25, 2025

@cfriedt cfriedt dismissed their stale review September 25, 2025 18:15

Although I disagree with the revert, I'm happy to resubmit 95226 after additional changes have been merged.

@cfriedt cfriedt merged commit fc5ded2 into zephyrproject-rtos:main Sep 25, 2025
52 of 54 checks passed
@fabiobaltieri fabiobaltieri deleted the posix-rollback branch September 25, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Build System area: C Library C Standard Library area: POSIX POSIX API Library Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc.

7 participants

@fabiobaltieri @cfriedt @kartben @nashif @henrikbrixandersen @aescolar @zephyrbot