Skip to content

Conversation

@it-klinger
Copy link
Contributor

Reopening the closed pull request.
Can anybody review the pull request, please?

@kartben
Copy link
Contributor

kartben commented Aug 10, 2025

Please reopen the original PR instead of opening a new one. Thanks!

@it-klinger
Copy link
Contributor Author

Hi Benjamin,
how can i reopen the closed PR?
I didn't find the knob.

Thalley and others added 14 commits August 10, 2025 11:59
Add a test for broadcast ISO that uses fragmentation. The host will attempt to send SDUs 3 times the HCI ISO data buffer size, so that it will be fragmented into a BT_ISO_START, BT_ISO_CONT and a BT_ISO_END HCI ISO data packet. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Enable support for building and running the BIS ISO host test on the nRF5340bsim board. The purpose of this is to test the ISO fragmentation on both the nRF52bsim and nRF5340bsim, as they use different drivers. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Add check that verifies that we do not have unexpected differences in timestamps. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Fixes some sonarcloud issues relating to the if statements. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Add initial Adafruit Metro RP2350 board definition. Signed-off-by: Peter Johanson <peter@peterjohanson.com>
- Adds CONFIG_FLASH_PAGE_LAYOUT check to the flash_mcux_flexspi drivers. - Saves some memory if FLASH_PAGE_LAYOUT is disabled. Signed-off-by: Andrej Butok <andrey.butok@nxp.com>
There does not appear to be any reason or pattern for this dtsi file to exist, so move everything to the dts file and delete it. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add bluetooth support to ESP32-C2 and ESP8684. Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com>
Add BT-HCI support to ESP32-C2 and ESP8684. Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com>
Add BT node to DTS for BT support. Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com>
Add testcase for esp8684_devkitm (ESP32-C2). Signed-off-by: Raffael Rostagno <raffael.rostagno@espressif.com>
When building with CONFIG_DEBUG=y, there is a build warning about the name being truncated due to integer size is larger than MAX_NAME_LEN. So fix MAX_NAME_LEN to be large enough to handle 10 digit integer, which is maximum. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
There was a deadlock occurring, exposed by http server sample because of situations like this caused by tx done work being blocked in deadlock: 1) The TX would be started by some thread and the driver TX sem would be taken. 2) The http server socket would get scheduled on the system workqueue to send something, claim the network TX interface mutex, and be blocked taking the semaphore. 3) The RX traffic class handler would get blocked trying to claim the network interface TX mutex, while trying to send an ACK in the TCP callback. This means the RX packets would not be processed. 4) Lots of RX unable to allocate packets errors would happen, and all RX would be dropped. This was the main symptom of the deadlock, which made it look like a memory leak but actually had nothing to do with the RX code nor any memory leak. 5) The TX DMA would finish and schedule the TX DMA done work onto the system work queue, behind the http server socket which is blocked on the waiting for the driver TX semaphore. 6) If the TX DMA done work would have ran, that's what gives the TX driver semaphore. So this is the reason for the deadlock of all these different threads and work items, the misqueue in the system workqueue. Fix by just calling the TX DMA done code directly from the ISR, it should be ISR safe, and really not a lot of code to execute, just freeing some net buffers and the packet and updating the stats. An optimization can be made later if needed, but for now, solving the deadlock is a more urgent priority. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Instead of blocking forever if TX is busy, return an error. This can avoid deadlock situations. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment