fix some incorrect syscall handlers #23308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
No check of the driver object was being performed for two APIs. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
andrewboie requested review from albertofloyd, franciscomunoz, mnkp, pabigot and scottwcpg as code owners andrewboie added Hotfix 
nashif reviewed Mar 6, 2020
drivers/gpio/gpio_handlers.c Outdated
No driver object checks were being performed for 3 APIs. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
andrewboie force-pushed the syscall-fixes branch from ac88538 to ed74a4a Compare 
franciscomunoz approved these changes Mar 6, 2020
d3zd3z approved these changes Mar 6, 2020
pabigot approved these changes Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
GPIO and kscan had problems in their syscall handlers where driver objects were not being validated.