-
- Notifications
You must be signed in to change notification settings - Fork 2
Update github-admonitions.css #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.x
Are you sure you want to change the base?
Conversation
Use CSS var to ease the changes
| Thanks Simon, but I'm a bit confused - should we update the css file to the value you show in #1 (comment)? |
| Wait, it was for the ux website ? 🥹 |
| It was, but I like that you added here. I was just trying to understand why the code changed in the PR was different from your comment. |
| padding-left: 1.5em; | ||
| background-repeat: no-repeat; | ||
| background-position-y: 50%; | ||
| color: var(--adminition-color, currentColor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a minor typo in the var name:
--adminition-color -> --admonition-color

Use CSS var to ease the changes