Skip to content

Adjust Types #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Adjust Types #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-deer-hug.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@zenml-io/react-component-library": patch
---

adjust types
4 changes: 2 additions & 2 deletions src/components/Table/DataTable.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ type DummyData = {
age: number;
};

const cols: ColumnDef<DummyData, unknown>[] = [
const cols: ColumnDef<DummyData>[] = [
{
id: "id",
header: "ID",
Expand Down Expand Up @@ -134,7 +134,7 @@ const CustomizedDataTable = () => {
);
};

const colsCustomized: ColumnDef<DummyData, unknown>[] = [
const colsCustomized: ColumnDef<DummyData>[] = [
{
id: "select",
accessorKey: "select",
Expand Down
8 changes: 4 additions & 4 deletions src/components/Table/Sorting.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ function SortingArrow({ direction }: Props) {
return <Comp className="h-4 w-4 shrink-0" />;
}

interface HeaderProps<TData extends RowData> {
header: Header<TData, unknown>;
interface HeaderProps<TData extends RowData, TValue> {
header: Header<TData, TValue>;
}

export function SortableHeader<TData extends RowData>({
export function SortableHeader<TData extends RowData, TValue>({
header,
children
}: PropsWithChildren<HeaderProps<TData>>) {
}: PropsWithChildren<HeaderProps<TData, TValue>>) {
return (
<button
className={`${
Expand Down