Trying to fix a platform issue with windows line ending

[mikeSimonson]

Uniformazing the line ending in the project to avoid issue
with windows.

Fix #45 and Fix #39

[krzysiekpiasecki]

IMHO we should always outputting with \PHP_EOL.

[mikeSimonson]

The problem is that you can only reliably split on "\n" and if you sometimes output code using PHP_EOL then you will leave some "\r" randomly in the output on windows. I don't know if it could cause issue though.

[mikeSimonson]

Ping @weierophinney

[Ocramius]

IMHO we should always outputting with \PHP_EOL.

The fact that this generates different code on windows and on proper operating systems (:trollface:) is already a show-stopper for using \PHP_EOL.

I think the fix is legit, but we need to check if the tests need some changes too. @mikeSimonson did you check if these modified paths are covered by tests that expect "\n" or \PHP_EOL?

[krzysiekpiasecki]

The fact that this generates different code on windows and on proper operating systems (:trollface:) is already a show-stopper for using \PHP_EOL.

This is the general idea. For example: Outputting to the files according to operation system sounds reasonable. When collaborating with files we have 'converters' etc. or maybe the better is using one proper operating system :)

This fix prevent us from bug observed on Windows machines during composer install when dealing with win files.

- $lines = explode(PHP_EOL, $body); + $lines = explode("\n", $body);

Nothing more is need it to fix this bug. Even tests are not necessary ;)

[Ocramius]

Outputting to the files according to operation system sound reasonable.

No, ZF in general has a "no dependency on configuration/environment", nor "modification of environment" policy.

The components should behave in the same way regardless of the OS. Generated code is considered an output.

[mikeSimonson]

@Ocramius Do I need to change anything ?

[Ocramius]

@mikeSimonson I'd need you to just check whether any tests are still relying on PHP_EOL. They should all verify only \n line-endings.

[mikeSimonson]

@Ocramius I think its fixed. There is only one reference left to PHP_EOL in this file. The test pass if it's uncommented and converted to \n. Should I add that too ?

The failure is only related to an update of phpcs. I am looking into the rule that need to be set to remove the failures.

[Ocramius]

@mikeSimonson thanks

[mikeSimonson]

@weierophinney Thanks