This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Fix exception message in ValueGenerator for invalid values #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When resource provided we should throw exception that this type cannot be used, but we tried to get_class on resource, what is invalid.
froschdesign approved these changes Dec 10, 2019
michalbundyra added a commit that referenced this pull request Dec 10, 2019
…alid-value Fix exception message in ValueGenerator for invalid values
michalbundyra added a commit that referenced this pull request Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When resource provided we should throw exception that this type
cannot be used, but we tried to get_class on resource, what is invalid.
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.Fixes #178