Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

fix Trying to access array offset on value of type nul (7.4) #172

Merged
merged 1 commit into from
Oct 5, 2019
Merged

fix Trying to access array offset on value of type nul (7.4) #172

merged 1 commit into from
Oct 5, 2019

Conversation

remicollet
Copy link
Contributor

With 7.4.0beta4

There were 16 errors: 1) ZendTest\Code\Scanner\ClassScannerTest::testClassScannerHasClassInformation Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:712 /work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:65 2) ZendTest\Code\Scanner\ClassScannerTest::testClassScannerHasMethods Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:712 /work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:89 3) ZendTest\Code\Scanner\ClassScannerTest::testHasMethod Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:846 /work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:139 4) ZendTest\Code\Scanner\ClassScannerTest::testClassScannerCanScanTraits Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:846 /work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:207 5) ZendTest\Code\Scanner\ClassScannerTest::testClassScannerCanGetTraitMethodsInGetMethods Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:746 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:709 /work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:267 6) ZendTest\Code\Scanner\ClassScannerTest::testGetMethodsThrowsExceptionOnDuplicateMethods Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:746 /work/GIT/zend/zend-code/test/Scanner/ClassScannerTest.php:293 7) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerHasMethodInformation Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:26 8) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerReturnsParameters Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:40 9) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerReturnsParameterScanner Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:49 10) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerParsesClassNames Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:60 11) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerReturnsPropertyWithNoDefault Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:70 12) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerReturnsLineNumbersForMethods Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:78 13) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerReturnsBodyMethods Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:87 14) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerMethodSignatureLatestOptionalParamHasParentheses Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:96 15) ZendTest\Code\Scanner\MethodScannerTest::testMethodScannerWorksWithSingleAbstractFunction Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/test/Scanner/MethodScannerTest.php:110 16) ZendTest\Code\Scanner\ParameterScannerTest::testParameterScannerHasParameterInformation Trying to access array offset on value of type null /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:455 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:592 /work/GIT/zend/zend-code/src/Scanner/MethodScanner.php:155 /work/GIT/zend/zend-code/src/Scanner/ClassScanner.php:827 /work/GIT/zend/zend-code/test/Scanner/ParameterScannerTest.php:22 ERRORS! Tests: 996, Assertions: 1557, Errors: 16, Skipped: 9, Incomplete: 4.
michalbundyra
michalbundyra reviewed Sep 2, 2019
View reviewed changes
src/Scanner/MethodScanner.php
$tokenContent = $token;
$tokenLine = $tokenLine + substr_count(
$lastTokenArray[1],
$lastTokenArray[1] ?? null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it works, but I would prefer another fix: we shouldn't call substr_count if the first argument is null. This is not a problem now, but when we add strict types it becomes an issue, see: https://www.php.net/substr_count
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a quick trivial fix (keeping same behavior)
But indeed, there is a logic error is this part of the code.
@michalbundyra michalbundyra changed the base branch from master to develop October 5, 2019 22:37
michalbundyra added a commit that referenced this pull request Oct 5, 2019
@michalbundyra
Merge pull request #172 from remicollet/issue-php-74
555667e 
fix Trying to access array offset on value of type nul (7.4)
michalbundyra added a commit that referenced this pull request Oct 5, 2019
@michalbundyra
Adds CHANGELOG entry for #172
bdcaaa6
michalbundyra added a commit that referenced this pull request Oct 5, 2019
@michalbundyra
Merge branch 'fix/172' into develop
f60a882 
Close #172
@michalbundyra michalbundyra merged commit 7ddf144 into zendframework:develop Oct 5, 2019
@michalbundyra
Copy link
Member

Thanks, @remicollet!
@michalbundyra michalbundyra added this to the 3.4.0 milestone Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement
2 participants
@remicollet @michalbundyra