This repository was archived by the owner on Jan 29, 2020. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork 79
Feature: Add ability to define declare statements #169
Merged
michalbundyra merged 7 commits into zendframework:develop from icanhazstring:feature/declare Oct 5, 2019
Merged
Changes from 5 commits
Commits
Show all changes
7 commits Select commit Hold shift + click to select a range
9a10b3b
Add ability to define declare statements
06bc7b7
Use php7.1 compliant functionality
1a82658
Rename class to match codesniffer rules
423e4c6
Code linting
bfd0c48
Improve test coverage
3e25e05
Fix grammar and typo
6918dee
Fix tests after typo
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,116 @@ | ||
<?php | ||
| ||
namespace Zend\Code; | ||
| ||
use Zend\Code\Exception\InvalidArgumentException; | ||
| ||
class DeclareStatement | ||
{ | ||
public const TICKS = 'ticks'; | ||
public const STRICT_TYPES = 'strict_types'; | ||
public const ENCODING = 'encoding'; | ||
| ||
private const ALLOWED = [ | ||
self::TICKS => 'integer', | ||
self::STRICT_TYPES => 'integer', | ||
self::ENCODING => 'string', | ||
]; | ||
| ||
/** | ||
* @var string | ||
*/ | ||
protected $directive; | ||
| ||
/** | ||
* @var int|string | ||
*/ | ||
protected $value; | ||
| ||
private function __construct(string $directive, $value) | ||
{ | ||
$this->directive = $directive; | ||
$this->value = $value; | ||
} | ||
| ||
/** | ||
* @return string | ||
*/ | ||
public function getDirective(): string | ||
{ | ||
return $this->directive; | ||
} | ||
| ||
/** | ||
* @return int|string | ||
*/ | ||
public function getValue() | ||
{ | ||
return $this->value; | ||
} | ||
| ||
/** | ||
* @param int $value | ||
* @return self | ||
*/ | ||
public static function ticks(int $value): self | ||
{ | ||
return new self(self::TICKS, $value); | ||
} | ||
| ||
/** | ||
* @param int $value | ||
* @return self | ||
*/ | ||
public static function strictTypes(int $value): self | ||
{ | ||
return new self(self::STRICT_TYPES, $value); | ||
} | ||
| ||
/** | ||
* @param string $value | ||
* @return self | ||
*/ | ||
public static function encoding(string $value): self | ||
{ | ||
return new self(self::ENCODING, $value); | ||
} | ||
| ||
public static function fromArray(array $config): self | ||
{ | ||
$directive = key($config); | ||
$value = $config[$directive]; | ||
| ||
if (! isset(self::ALLOWED[$directive])) { | ||
throw new InvalidArgumentException( | ||
sprintf( | ||
'Declare directive must be on of: %s.', | ||
implode(', ', array_keys(self::ALLOWED)) | ||
) | ||
); | ||
} | ||
| ||
if (gettype($value) !== self::ALLOWED[$directive]) { | ||
throw new InvalidArgumentException( | ||
sprintf( | ||
'Declare value invalid. Expected %s got %s.', | ||
icanhazstring marked this conversation as resolved. Outdated Show resolved Hide resolved | ||
self::ALLOWED[$directive], | ||
gettype($value) | ||
) | ||
); | ||
} | ||
| ||
$method = str_replace('_', '', lcfirst(ucwords($directive, '_'))); | ||
| ||
return self::{$method}($value); | ||
} | ||
| ||
/** | ||
* @return string | ||
*/ | ||
public function getStatement(): string | ||
{ | ||
$value = is_string($this->value) ? '\'' . $this->value . '\'' : $this->value; | ||
| ||
return sprintf('declare(%s=%s);', $this->directive, $value); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.