Fix multiple [Producer name] tags on failures #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ojab force-pushed the fixup_infinite_tags branch from 107d507 to 9121246 Compare On `rescue Kafka::Error` we're rerunning the whole method block including `@logger.push_tags(@producer.to_s)`, but clearing tags only in `ensure` which is not run on `retry`
ojab force-pushed the fixup_infinite_tags branch from 9121246 to 68b8761 Compare | CI failures look unrelated. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
On
rescue Kafka::Errorwe're rerunning the whole method blockincluding
@logger.push_tags(@producer.to_s), but clearing tagsonly in
ensurewhich is not run onretry, so each retry addsanother one
[Producer name]to tags and, as a consequence, allthe log messages after that.