Skip to content

Make verify_hostname settable for ssl contexts #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2020
Merged

Make verify_hostname settable for ssl contexts #828

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07faba2
Fixup verify_hostname for ssl contexts
lairen May 11, 2020
c352cd7
Update README.md
lairen May 15, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/kafka/ssl_context.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,12 @@ def self.build(ca_cert_file_path: nil, ca_cert: nil, client_cert: nil, client_ce
store.set_default_paths
end
ssl_context.cert_store = store
ssl_context.verify_mode = OpenSSL::SSL::VERIFY_PEER
# Verify certificate hostname if supported (ruby >= 2.4.0)
ssl_context.verify_hostname = verify_hostname if ssl_context.respond_to?(:verify_hostname=)
end

ssl_context.verify_mode = OpenSSL::SSL::VERIFY_PEER
# Verify certificate hostname if supported (ruby >= 2.4.0)
ssl_context.verify_hostname = verify_hostname if ssl_context.respond_to?(:verify_hostname=)

ssl_context
end
end
Expand Down