Skip to content

Conversation

@lxgr-linux
Copy link
Contributor

@lxgr-linux lxgr-linux commented Sep 3, 2025

This PR adds run options to run main classes and tests via the IDE.
One problem I wasnt able to overcome was me not being able to dynamically decide whether to use maven or gradle to run.

An option would be to ship a script that, proxys maven and gradle and decides which one to use. But i don't know how elegant that would be. The Solution rn is just to show both options always.

@cla-bot
Copy link

cla-bot bot commented Sep 3, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @lxgr-linux on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@lxgr-linux
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 3, 2025
@cla-bot
Copy link

cla-bot bot commented Sep 3, 2025

The cla-bot has been summoned, and re-checked this pull request!

@lxgr-linux
Copy link
Contributor Author

I now resorted to having inline scripts to decide what build system to use

@tartarughina
Copy link
Collaborator

If you could add a short video showcasing the changes it would make reviewing this PR a lot easier

@lxgr-linux
Copy link
Contributor Author

lxgr-linux commented Sep 5, 2025

Bildschirmaufzeichnung.vom.2025-09-05.09-48-43.mp4

@tartarughina
Here you can see me being able to start an application and execute tests right from the editor window.

Copy link
Collaborator

@tartarughina tartarughina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the demo.

It covered all possible instances where Gradle or Maven should execute main, tests or more broadly the main class and a test class.
I especially like the inline selection of the project manager in the tasks.

Super nitpick and not really sure how useful it could be: it would be nice to have a third option where the main class could be executed without any project manager. Something really beginner friendly but for sure not blocking.

@lxgr-linux
Copy link
Contributor Author

Thanks for the feedback, I also thought about that, but since thats not likely to happen I left it out.

I also would need a review by a codeowner.

@tartarughina
Copy link
Collaborator

Copy link

@heuerleon heuerleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! It would be nice if a code owner could review this as well

@MrSubidubi MrSubidubi linked an issue Oct 3, 2025 that may be closed by this pull request
@MrSubidubi MrSubidubi changed the title #45 Adds run option Add runnables queries Oct 3, 2025
Copy link
Contributor

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, looks good! Thank you very much!


On a related note: If anyone of you (or some of you together) are interested in maintaining this extension on the side, feel free to ping me here and we can discuss this further. Thanks!

@MrSubidubi MrSubidubi merged commit db26915 into zed-extensions:main Oct 3, 2025
1 check passed
@MrSubidubi MrSubidubi mentioned this pull request Oct 3, 2025
MrSubidubi added a commit that referenced this pull request Oct 3, 2025
This PR bump the version of the extension to 6.5.0. Includes: - #79 - #84 - #85 - #87
MrSubidubi added a commit to zed-industries/extensions that referenced this pull request Oct 3, 2025
This PR bump the version of the Java extension to 6.5.0. Includes: - zed-extensions/java#79 - zed-extensions/java#84 - zed-extensions/java#85 - zed-extensions/java#87
@tartarughina
Copy link
Collaborator

On a related note: If anyone of you (or some of you together) are interested in maintaining this extension on the side, feel free to ping me here and we can discuss this further. Thanks!

@MrSubidubi let's do it

@MrSubidubi
Copy link
Contributor

@tartarughina Sent you an invite as well.

I'd kindly ask you and @playdohface to find a way to communicate so you don't conflict with the changes you both are planning, don't want any of you to waste your time here and am very grateful for your efforts.
Happy to chime in there as well if you'd like me to, i.e. we could have a channel on Discord so you can also ask questions and raise stuff if you'd like.

Also, again, big thank you to @valentinegb for all your work prior, mentioned this before but will mention it again.

@playdohface
Copy link
Collaborator

@tartarughina @MrSubidubi happy to contribute, and for discussions as long as we are diligent with keeping the issues updated I don't think we will step on each others feet, quite the contrary actually

@tartarughina
Copy link
Collaborator

Happy to chime in there as well if you'd like me to, i.e. we could have a channel on Discord so you can also ask questions and raise stuff if you'd like.

I love the idea of using Discord as secondary channel. Everything related to this extension should be handled as a comment to an issue.

I don't know how other extensions handle it but have they created groups underneath the main Zed channel?

@MrSubidubi
Copy link
Contributor

@tartarughina Frankly, we haven't yet done somethinig like this on the Discord server. I like the idea though and will bring this up internally, let's see how it goes (don't just wanna do it because we made some changes there recently, but will push for it).

For now, sent you a friend request and we can go from there if it's fine?

Mazurel pushed a commit to Mazurel/extensions that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants