-
Couldn't load subscription status.
- Fork 28
Add runnables queries #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| We require contributors to sign our Contributor License Agreement, and we don't have @lxgr-linux on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
| @cla-bot check |
| The cla-bot has been summoned, and re-checked this pull request! |
| I now resorted to having inline scripts to decide what build system to use |
| If you could add a short video showcasing the changes it would make reviewing this PR a lot easier |
Bildschirmaufzeichnung.vom.2025-09-05.09-48-43.mp4@tartarughina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the demo.
It covered all possible instances where Gradle or Maven should execute main, tests or more broadly the main class and a test class.
I especially like the inline selection of the project manager in the tasks.
Super nitpick and not really sure how useful it could be: it would be nice to have a third option where the main class could be executed without any project manager. Something really beginner friendly but for sure not blocking.
| Thanks for the feedback, I also thought about that, but since thats not likely to happen I left it out. I also would need a review by a codeowner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! It would be nice if a code owner could review this as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, looks good! Thank you very much!
On a related note: If anyone of you (or some of you together) are interested in maintaining this extension on the side, feel free to ping me here and we can discuss this further. Thanks!
This PR bump the version of the Java extension to 6.5.0. Includes: - zed-extensions/java#79 - zed-extensions/java#84 - zed-extensions/java#85 - zed-extensions/java#87
@MrSubidubi let's do it |
| @tartarughina Sent you an invite as well. I'd kindly ask you and @playdohface to find a way to communicate so you don't conflict with the changes you both are planning, don't want any of you to waste your time here and am very grateful for your efforts. Also, again, big thank you to @valentinegb for all your work prior, mentioned this before but will mention it again. |
| @tartarughina @MrSubidubi happy to contribute, and for discussions as long as we are diligent with keeping the issues updated I don't think we will step on each others feet, quite the contrary actually |
I love the idea of using Discord as secondary channel. Everything related to this extension should be handled as a comment to an issue. I don't know how other extensions handle it but have they created groups underneath the main Zed channel? |
| @tartarughina Frankly, we haven't yet done somethinig like this on the Discord server. I like the idea though and will bring this up internally, let's see how it goes (don't just wanna do it because we made some changes there recently, but will push for it). For now, sent you a friend request and we can go from there if it's fine? |
This PR bump the version of the Java extension to 6.5.0. Includes: - zed-extensions/java#79 - zed-extensions/java#84 - zed-extensions/java#85 - zed-extensions/java#87
This PR adds run options to run main classes and tests via the IDE.
One problem I wasnt able to overcome was me not being able to dynamically decide whether to use maven or gradle to run.An option would be to ship a script that, proxys maven and gradle and decides which one to use. But i don't know how elegant that would be. The Solution rn is just to show both options always.