Skip to content

Conversation

@Ilanaya
Copy link
Collaborator

@Ilanaya Ilanaya commented Feb 18, 2024

You can see the bug here: https://github.com/zardoy/typescript-vscode-plugins/actions/runs/7950003246/job/21701805850#step:9:30

Or on this screenshot (received should be expected and vice versa):
image

@Ilanaya Ilanaya requested a review from zardoy February 18, 2024 18:52
Copy link
Owner

@zardoy zardoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Ilanaya Ilanaya changed the title fix(tests): expected and recieved results are mixed up fix(tests): expected and received results are mixed up Feb 19, 2024
@Ilanaya Ilanaya merged commit a952c9f into develop Feb 19, 2024
@zardoy
Copy link
Owner

zardoy commented Feb 19, 2024

btw i dont think test issue should be included into changelog next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants